Opened 2 years ago
Last modified 2 years ago
#22328 new defect
[Patch] Nodes should be exclude from "construction:highway without highway and construction"
Reported by: | skyper | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | latest |
Keywords: | template_report node construction highway railway | Cc: | mkoniecz, gaben |
Description (last modified by )
What steps will reproduce the problem?
- Have a node with
construction:highway=*
, e.g. api/0.6/node/303193688/26 - Run validator
What is the expected result?
No warning
What happens instead?
construction:highway without highway and construction
highway together with construction:highway and conflicting values plus no construction
Please provide any additional information below. Attach a screenshot if possible.
The validator test should exclude nodes. Same might be true for railway
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2022-08-29 16:59:00 +0200 (Mon, 29 Aug 2022) Revision:18543 Build-Date:2022-08-30 01:30:57 URL:https://josm.openstreetmap.de/svn/trunk
Attachments (1)
Change History (6)
comment:1 by , 2 years ago
Description: | modified (diff) |
---|
by , 2 years ago
Attachment: | josm_22328.patch added |
---|
comment:2 by , 2 years ago
Milestone: | → 22.09 |
---|---|
Summary: | Nodes should be exclude from "construction:highway without highway and construction" → [Patch] Nodes should be exclude from "construction:highway without highway and construction" |
comment:3 by , 2 years ago
I'm not certain about this -- do we have wiki documentation on this?
highway=crossing
+ crossing=uncontrolled
+ construction:crossing=traffic_signals
+ construction:highway=traffic_signals
maybe should be
highway=crossing
+ crossing=uncontrolled
+ construction:crossing=traffic_signals
+ construction=traffic_signals
.
Maybe we should add the active commentators on #17607 here?
comment:4 by , 2 years ago
Cc: | added |
---|---|
Milestone: | 22.09 |
Unfortunately, there is only little documentation and it is either general (construction=*
) or only about ways (highway=construction
). Though, nodes are not excluded in the wiki.
Maybe, it is better to use the scheme for all object types. Opinions?
By the way, we should warn about construction=highway/railway/building/landuse
.
Edit: Probably one reason for my interpretation of excluding nodes are the missing values in presets and data, so far.
comment:5 by , 2 years ago
Maybe this warning should be raised only on construction:highway
values matching way classes such as motorway
or path
or cycleway
or tertiary
?
patch, only using way and relation for highway and railway