IAE in org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$DeleteAction.deleteRelation

[anonymous]

What steps will reproduce the problem?

Use turnrestrictions module

1. Create new turn restriction
2. Select created turn restriction on the module panel
3. Delete selected turn restriction by pressing trash button on the module panel.

What is the expected result?

delete selected restriction

What happens instead?

Module error dialog appears

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-07-07 23:02:39 +0200 (Thu, 07 Jul 2022)
Build-Date:2022-07-08 01:30:57
Revision:18513
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18513 ru) Windows 7 64-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 934 MB / 1820 MB (269 MB allocated, but free)
Java version: 1.8.0_333-b02, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1251
System property sun.jnu.encoding: Cp1251
Locale info: ru_RU
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1623509627)
+ FastDraw (35978)
+ apache-commons (35924)
+ apache-http (35924)
+ buildings_tools (35997)
+ hexgrid-generator (0.0.2)
+ imagery_offset_db (35978)
+ jna (35924)
+ photo_geotagging (35933)
+ reltoolbox (35976)
+ russia-address-helper (0.8.0)
+ tageditor (35893)
+ todo (30306)
+ turnlanes-tagging (v0.0.5)
+ turnrestrictions (35976)
+ utilsplugin2 (36001)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-highways&zip=1
+ C:\Program Files (x86)\JOSM\PG-JOSM-presets.xml
+ https://raw.githubusercontent.com/ruosm-presets/literan-moscow/master/russian_shops.xml
+ <josm.pref>/EasyPresets.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- %UserProfile%\JOSM Modifyed objects style

Last errors/warnings:
- 00010.347 E: java.nio.file.NoSuchFileException: C:\Program Files (x86)\JOSM\PG-JOSM-presets.xml
- 00010.348 E: C:\Program Files (x86)\JOSM\PG-JOSM-presets.xml
- 00010.380 E: Не удалось найти изображение «pics/icons/Russian_Post.svg»
- 00010.381 W: [NODE, CLOSEDWAY, MULTIPOLYGON] Russian Post: Could not get presets icon pics/icons/Russian_Post.svg
- 00010.758 E: Не удалось найти изображение «https://image.flaticon.com/icons/png/512/47/47421.png»
- 00010.766 W: [NODE, CLOSEDWAY, MULTIPOLYGON] Clothes dryer: Could not get presets icon https://image.flaticon.com/icons/png/512/47/47421.png
- 00022.022 E: Не удалось найти изображение «modified_objects_style_icon.svg»
- 00022.025 W: Mappaint style "standard" (Modified objects) icon "modified_objects_style_icon.svg" not found.
- 00407.767 E: Handled by bug report queue: java.lang.IllegalArgumentException: {Relation id=-99753 version=0 MVDT]} is already deleted



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (19) of main
java.lang.IllegalArgumentException: {Relation id=-99753 version=0 MVDT]} is already deleted
	at org.openstreetmap.josm.command.DeleteCommand.lambda$executeCommand$0(DeleteCommand.java:211)
	at org.openstreetmap.josm.data.osm.DataSet.update(DataSet.java:1003)
	at org.openstreetmap.josm.command.DeleteCommand.executeCommand(DeleteCommand.java:207)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:300)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:354)
	at org.openstreetmap.josm.actions.mapmode.DeleteAction.deleteRelations(DeleteAction.java:367)
	at org.openstreetmap.josm.actions.mapmode.DeleteAction.deleteRelation(DeleteAction.java:348)
	at org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$DeleteAction.deleteRelation(TurnRestrictionsListDialog.java:274)
	at org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$DeleteAction.actionPerformed(TurnRestrictionsListDialog.java:285)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[taylor.smock]

In 36009/osm:

Fix #22223: IAE in org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$DeleteAction.deleteRelation

This also fixes a similar IAE in TurnRestrictgionEditor.

[taylor.smock]

In 36010/osm:

dist

See #22223: IAE in org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$DeleteAction.deleteRelation

This is also the dist for updates to ivy dependencies in:

• apache-commons (see r36003/osm)
• geotools (see r36008/osm)
• jackson (see r36006/osm)
• jna (see r36005/osm)
• jts (see r36004/osm)
• log4j (see r36007/osm)