Enhancement request about the continuity line for superroutes in the relation editor

[pelderson@…]

What steps will reproduce the problem?

1. With the JOSM relation editor, open a superroute relation containing properly ordered member relations, which are themselves complete and properly ordered.
2. Open one of the member relations, remove a way (not the first or last) and save.
3. Look at the continuity line in the superroute relation editor window.

What is the expected result?

It would make route mappers very happy if the continuity line would show that the member route relation is internally interrupted. Currently, the member route relations have to be opened one by one to check their continuity lines.

E.g. a red circle or hyphen in the middle of the vertical continuity bar section would do the trick for the route mapper.

What happens instead?

The interruption within the member route relation is not visible in the superroute. The superroute appears to be uninterrupted but in fact the route is not complete.

Please provide any additional information below. Attach a screenshot if possible.

The fact that the member relations may themselves be superroutes is probably a complicating factor - but I think the current continuity check already handles that.

Revision:18463
Build-Date:2022-05-30 10:23:53

Identification: JOSM/1.5 (18463 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19043)
Memory Usage: 642 MB / 1910 MB (98 MB allocated, but free)
Java version: 17.0.3+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.25×1.25)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: nl_NL
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18463, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ CommandLine (35951)
+ PolygonCutOut (v0.7)
+ apache-commons (35924)
+ apache-http (35924)
+ changeset-viewer (v0.0.4)
+ dataimport (35932)
+ ejml (35924)
+ geotools (35959)
+ imagery_offset_db (35893)
+ jackson (35958)
+ jaxb (35952)
+ jna (35924)
+ jts (35924)
+ opendata (35910)
+ reverter (35972)
+ turnrestrictions (35893)
+ utilsplugin2 (35970)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Stolpersteine&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/StolpersteineLight&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1
+ %UserProfile%\Google Drive\_PETER\OSM\_Diversen\Styles_NumberedWalkingNodeNetworks\Styles_NumberedWalkingNodeNetworks2-style.mapcss

Last errors/warnings:
- 00001.244 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00001.250 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00006.118 E: java.security.KeyStoreException: Windows-ROOT not found. Oorzaak: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00021.443 W: Laden van Kaarttekenstijlen vanaf '%UserProfile%\Google Drive\_PETER\OSM\_Diversen\Styles_NumberedWalkingNodeNetworks\Styles_NumberedWalkingNodeNetworks2-style.mapcss' mislukt. Exceptie was: java.nio.file.NoSuchFileException: %UserProfile%\Google Drive\_PETER\OSM\_Diversen\Styles_NumberedWalkingNodeNetworks\Styles_NumberedWalkingNodeNetworks2-style.mapcss
- 00021.445 E: java.nio.file.NoSuchFileException: %UserProfile%\Google Drive\_PETER\OSM\_Diversen\Styles_NumberedWalkingNodeNetworks\Styles_NumberedWalkingNodeNetworks2-style.mapcss
- 00021.451 E: java.nio.file.NoSuchFileException: %UserProfile%\Google Drive\_PETER\OSM\_Diversen\Styles_NumberedWalkingNodeNetworks
- 00021.453 W: Initializing map style %UserProfile%\Google Drive\_PETER\OSM\_Diversen\Styles_NumberedWalkingNodeNetworks\Styles_NumberedWalkingNodeNetworks2-style.mapcss voltooid in 13 ms (1 errors, 0 warnings)
- 00028.775 W: Cannot lock cache directory. Will not use disk cache
- 00044.279 W: Cannot start IPv4 remotecontrol server on port 8111: Address already in use: bind
- 00044.335 W: Cannot start IPv6 remotecontrol server on port 8111: Address already in use: bind

[pyrog]

Relation type=superroute with members ordered in relation editor

[pyrog]

What I observed is that if I repair the members order in a sub relation (sort them, add a way to fill a gap…) I must close the route editor (of the super route) and reopen it to see any effects.
(Or change the type to i.e. route save, and restore type to superroute and save).

So a manual (or better an automatic) update of the superroute is missing.

(reminder for myself: continuity line for superroutes were added in revision 15732).

[skyper]

I like the feature that I do not have to download all members of the children's relations and I am not sure if checking them all is a goal performance wise. I'd rather prefer validator test looking for gaps in route relations similar to the ones in pt_assistance plugin which as far as I remember already supports more than just public transportation routes.