[PATCH][RFC] psv=yes on barrier=lift_gate suspicious?

[Gazer75]

This should be perfectly valid for automated lift gates that let these vehicles through. Typically bus, garbage truck and emergency services.

[taylor.smock]

This is probably from source:trunk/resources/data/validator/combinations.mapcss#L483​ (see r14975/#17572 for initial barrier exclusion). Which was originally added in r6548 (migrations), but r4777/#5017 appears to be the originating commit for this check ("Testing for typical tag combinations (derived from Taginfo)").

Anyway, looking at ​https://wiki.openstreetmap.org/w/index.php?title=Tag:barrier%3Dlift_gate&oldid=418304, access=* has been valid for some time for lift gates. I'd prefer to have a list of barrier types that are ok for psv=*, but that is a good chunk of them.

• bollard
• lift_gate
• sliding_beam
• height_restrictor(are there instances where psv is ok but non-psv is not?)
• sliding_gate
• gate
• entrance
• coupure(maybe there are some for psv only?)
• cattle_grid
• bus_trap
• bump_gate
• sally_port
• spikes
• swing_gate
• toll_booth
• yes
• chain
• rope
• jersey_barrier(are there motorized variants?)
• kerb
• Anything else that I missed.

resources/data/validator/combinations.mapcss

@@ -480 +480 @@
 way[lanes  ][!barrier][!ford][!highway ][!area:highway][!junction][leisure!~/^(bowling_alley|slipway|swimming_pool|track)$/][!traffic_calming]!.only_one_tag,
 *[tunnel   ][!highway][!area:highway][!railway][!waterway][!piste:type][type!=tunnel][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=tunnel][power!=cable],
 *[bridge   ][!highway][!area:highway][!railway][!waterway][!piste:type][type!=bridge][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=bridge][building!=bridge],
-*[psv      ][!highway][!area:highway][!railway][!waterway][barrier!=bollard][amenity !~ /^parking.*/],
+*[psv      ][!highway][!area:highway][!railway][!waterway][barrier !~ /^(bollard|bump_gate|bus_trap|cattle_grid|chain|coupure|entrance|gate|height_restrictor|jersey_barrier|kerb|lift_gate|rope|sally_port|sliding_beam|sliding_gate|spikes|swing_gate|toll_booth|yes)$/][amenity !~ /^parking.*/],
 *[width    ][!highway][!area:highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance][natural!=stone][leisure!=track],
 *[maxspeed ][!highway][!area:highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][traffic_sign:forward !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][traffic_sign:backward !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(canal|fairway|lock|river|tidal_channel)$/][!traffic_calming][aerialway!=zip_line],
 way[incline][!highway][!area:highway][!railway][aeroway!~/^(runway|taxiway)$/][attraction!=summer_toboggan][leisure!=slipway] {

[Klumbumbus]

So should we apply the patch as is?

[taylor.smock]

We definitely could. I just tend to be a bit more cautious on tagging changes. In other words, I wanted to give people a chance to tell me I'm an idiot. :)

TBH, I'd prefer to add whitelisted values, but that is a lot of values to whitelist. [barrier!=bollard][barrier!=lift_gate][...]

[Klumbumbus]

You could use the a regex to have a bit more human readable overview about the values list, but I don't know if this is better performance wise.
[barrier!~/^(bollard|lift_gate|...)$/]

[taylor.smock]

On a file with 2,157,637 features, after adding psv=yes to everything,
CPU samples and Memory allocations were done using MapCSSTagChecker.check(OsmPrimitive)

Type	Time	CPU samples	Memory
Original	3:07	74,538	35,386,991,672
Regex	4:40	114,056	34,628,652,016
[!=]	5:37	118,006	34,990,241,112

So the regex is (surprisingly) cheaper than the [barrier!=bollard][barrier!=lift_gate][...] alternative. But is still much worse when compared to the original version.
EDIT: Add original version for comparison (barrier!=bollard)

[taylor.smock]

In 18522/josm:

Fix #22166: ignore more barrier types for psv suspicious tag combination