New core keyboard shortcut for "Save Session" same as "Add Source Tag"

[skyper]

What steps will reproduce the problem?

1. Install utilsplugin2

What is the expected result?

No keyboard shortcut conflict

What happens instead?

The core action "Save Session" occupies the shortcut for "Add Source Tag", Ctrl+Alt+S.

2022-06-24 16:56:23.160 INFO: Missing preference file '/home/user/.config/"josm-latest"/preferences.xml'. Creating a default preference file.
…
2022-06-24 16:57:28.493 INFO: Downloading Plugin utilsplugin2...
2022-06-24 16:57:29.339 INFO: GET https://josm.openstreetmap.de/osmsvn/applications/editors/josm/dist/utilsplugin2.jar -> HTTP/1.1 200 (845 ms; 356 kB)
2022-06-24 16:57:32.462 INFO: loading plugin 'utilsplugin2' (version 35970)
2022-06-24 16:57:32.498 INFO: Reassigning shortcut 'tools:sourcetag' from null to 576 because of conflict with Ctrl+Alt+S
2022-06-24 16:57:32.498 INFO: Silent shortcut conflict: 'tools:sourcetag' moved by 'system:savesession' to 'Alt+Shift+F1'.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-06-23 00:47:56 +0200 (Thu, 23 Jun 2022)
Revision:18499
Build-Date:2022-06-23 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18499 en) Linux Debian GNU/Linux 11 (bullseye)
Memory Usage: 516 MB / 2970 MB (298 MB allocated, but free)
Java version: 17.0.3+7-Debian-1deb11u1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00) :0.1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME
fonts-noto: fonts-noto:all-20201225-1
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djosm.dir.name="josm-latest", -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ utilsplugin2 (35970)

[taylor.smock]

Stupid question: Does anyone still recommend adding source tags to individual objects? If not, then we could probably remove the default keyboard shortcut for it in utilsplugin2.

[skyper]

+1 for removing the shortcut.
source tags should be added to the changeset and not to each individual object though there are a number of cases where it might be still useful like ptv2 relations imported from gtfs (each with individual source) or a handful of new buildings which are missing in the primary source.

[taylor.smock]

In 36001/osm:

fix #22163: utilsplugin2 TagSourceAction has the same shortcut as Save Session

As adding a source tag to objects is no longer recommended, removing the
default shortcut should not cause issues. If users still want to use the
shortcut, they can change it back in preferences.

[taylor.smock]

In 36002/osm:

see #22163 (dist): utilsplugin2 TagSourceAction has the same shortcut as Save Session

As adding a source tag to objects is no longer recommended, removing the
default shortcut should not cause issues. If users still want to use the
shortcut, they can change it back in preferences.