Modify ↓

Opened 3 years ago

Closed 15 months ago

Last modified 14 months ago

#22134 closed defect (fixed)

[PATCH] Incorrect mappaint on roundabouts when used with cycleway=shared_lane

Reported by: gaben Owned by: team
Priority: minor Milestone: 23.11
Component: Internal mappaint style Version:
Keywords: shared_lane roundabout Cc: Klumbumbus

Description

cycleway=shared_lane painting on roundabouts is inaccurate because roundabouts are oneway by default and JOSM paints shared_lane markings on both sides.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-06-09 19:22:55 +0200 (Thu, 09 Jun 2022)
Build-Date:2022-06-10 01:30:55
Revision:18485
Relative:URL: ^/trunk

Attachments (0)

Change History (8)

comment:1 by gaben, 19 months ago

Or is it an issue?

comment:2 by gaben, 17 months ago

Rendering should be similar to cycleway:<left|right>=shared_lane depending on the country (direction of the roundabout).

What do you think?

comment:3 by taylor.smock, 17 months ago

Milestone: → 23.08
Summary: Incorrect mappaint on roundabouts when used with cycleway=shared_lane → [PATCH] Incorrect mappaint on roundabouts when used with cycleway=shared_lane

This would probably "fix" the problem:

  • resources/styles/standard/elemstyles.mapcss 

    diff --git a/resources/styles/standard/elemstyles.mapcss b/resources/styles/standard/elemstyles.mapcss
    a b  
    10421042}
    10431043
    10441044    /* prepare shared_lane */
    1045 way[oneway?][cycleway=shared_lane]:righthandtraffic::core_cycleway {
     1045way[oneway?][cycleway=shared_lane]:righthandtraffic::core_cycleway,
     1046way[!oneway][cycleway=shared_lane][junction=roundabout]:righthandtraffic::core_cycleway {
    10461047    set shared_laneRight;
    10471048    set righthandtr;
    10481049}
    … …  
    10501051    set shared_laneLeft;
    10511052    set righthandtr;
    10521053}
    1053 way[oneway?][cycleway=shared_lane]!.righthandtr::core_cycleway {
     1054way[oneway?][cycleway=shared_lane]!.righthandtr::core_cycleway,
     1055way[!oneway][cycleway=shared_lane][junction=roundabout]!.righthandtr::core_cycleway {
    10541056    set shared_laneLeft;
    10551057}
    10561058way[oneway=-1][cycleway=shared_lane]!.righthandtr::core_cycleway {
    … …  
    10631065    set shared_laneRight;
    10641066}
    10651067way[oneway=no][cycleway=shared_lane]::core_cycleway,
    1066 way[!oneway][cycleway=shared_lane]::core_cycleway,
     1068way[!oneway][junction!=roundabout][cycleway=shared_lane]::core_cycleway,
    10671069way[oneway?][oneway:bicycle=no][cycleway=shared_lane]::core_cycleway,
    10681070way[cycleway:both=shared_lane]::core_cycleway {
    10691071    set shared_laneLeft;

I honestly don't know if that is the best solution though.

comment:4 by gaben, 17 months ago

Cc: Klumbumbus added

comment:5 by taylor.smock, 16 months ago

Milestone: 23.08 → 23.09

Ticket retargeted after milestone closed

comment:6 by taylor.smock, 15 months ago

Resolution: → fixed
Status: new → closed

In 18835/josm:

Fix #22134: Only show cycle dashes on one side of roundabout

comment:7 by taylor.smock, 15 months ago

Milestone: 23.09 → 23.10

Ticket retargeted after milestone deleted

comment:8 by taylor.smock, 14 months ago

Milestone: 23.10 → 23.11

Ticket retargeted after milestone deleted

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.