[PATCH] Add 'school=entrance' to deprecation warnings

[pietervdvn]

What steps will reproduce the problem?

1. Add a 'school=entrance' to a point
2. Try to upload
3. Uploading succeeds without warnings

What is the expected result?

A validator error which encourages contributors to use entrance=main instead

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-05-29 21:53:52 +0200 (Sun, 29 May 2022)
Revision:18463
Build-Date:2022-05-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18463 en) Linux Ubuntu 20.04.4 LTS
Memory Usage: 882 MB / 3954 MB (318 MB allocated, but free)
Java version: 11.0.15+10-Ubuntu-0ubuntu0.20.04.1, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00) :0.1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
Java package: openjdk-11-jre:amd64-11.0.15+10-0ubuntu0.20.04.1
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20200323-1build1~ubuntu20.04.1
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-beta.10)
+ PicLayer (1.0.2)
+ apache-commons (35924)
+ apache-http (35924)
+ jna (35924)
+ pbf (35893)
+ reverter (35972)
+ todo (30306)
+ utilsplugin2 (35970)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1

Last errors/warnings:
- 01897.641 E: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 01899.248 W: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 01899.248 W: Already here java.net.SocketException: Socket closed
- 01899.248 E: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 01900.272 W: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 01900.272 W: Already here java.net.SocketException: Socket closed
- 01900.273 E: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 01900.807 W: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed
- 01900.807 W: Already here java.net.SocketException: Socket closed
- 01900.807 E: java.net.SocketException: Socket closed. Cause: java.net.SocketException: Socket closed

[taylor.smock]

Looking at the history, the tag was recently added as a tagging mistake (by someone with the screen name as you).(1)
I also don't see anything on the talk page or in the tagging mailing list (archives for 2022-06) for school=entrance.

As such, I'm disinclined to add it to any validator warning or automatically replacing it. I know this is probably not what you wanted to hear, but I do not want to make tagging changes for anything which has just changed, or might have just changed. I will make exceptions for items that have been discussed on the tagging mailing list and/or has gone through the proposal process. Otherwise, for changes to the wiki, I have to apply "does this make sense", and if so, "was this just changed?". Typically, for any change older than 2 or 3 years, I presume that those who care have looked at it.

So if you did discuss it on the mailing list, please post a link to the start of the thread. It is entirely possible that I missed it.

With that said, (2) indicates that replacing school=entrance with entrance=main would not make sense in context of what the wiki said prior to the removal of school=entrance:

Consider adding school=entrance and if appropriate barrier=gate to the points where roads, paths or other access routes into the school grounds cross the boundary of the school (which is tagged with amenity=school.

​osmwiki:Tag:entrance=main

The main entrance of a building or enclosed area.

Note that there is no reference to "the main entrance of the school grounds" for school=entrance. So entrance=yes would be the closest tag.

(1) ​https://wiki.openstreetmap.org/w/index.php?title=Key:entrance&oldid=2339245
(2) ​https://wiki.openstreetmap.org/w/index.php?title=Tag:amenity%3Dschool&diff=prev&oldid=1087074

[pietervdvn]

Hi Taylor,

You're only doing your duties

Yes, I did make some wiki updates. However, the deprecation warning on school=entrance has been there for ages, and the second diff that you point out (replacing school=entrance with entrance=main) is already 8 years old.

Entrance=main might not be the most appropriate tag, but entrance=yes certainly is. In some cases, an additional barrier=gate (or bollard or similar) might be appropriate, but this is not always the case.

[taylor.smock]

For future readers:

pietervdvn has brought this up on the tagging list ( ​https://lists.openstreetmap.org/pipermail/tagging/2022-June/064815.html )

It does look like the ​osmwiki:Key:school page has indicated that people should avoid using school=entrance since 2018 (see ​https://wiki.openstreetmap.org/w/index.php?title=Key%3Aschool&type=revision&diff=1610243&oldid=555416 ), and has slightly stronger language starting in 2022 (see ​https://wiki.openstreetmap.org/w/index.php?title=Key:school&diff=prev&oldid=2324892 ).

@pietervdvn: Thank you for bringing it up on the tagging list. (For the record, I think deprecating school=entrance and replacing it with entrance=yes makes sense (for nodes), it was just the recent change(s) to the wiki that have made me a bit cautious).

Anyway, I figure giving people a month or two to respond to the tagging thread should be good enough. If I forget about this (definitely a possibility), feel free to ping this around August 10th.

[pietervdvn]

Allright, I wrote it down. I just made an official deprecation proposal too: ​https://wiki.openstreetmap.org/wiki/Proposed_features/Key:school%3Dentrance#Rationale

Thanks for doing your due diligence

[taylor.smock]

resources/data/validator/deprecated.mapcss

@@ -2373 +2373 @@
   assertMatch: "node role=stop";
 }
 
+/* #22120 */
+*[school=entrance] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "entrance=yes";
+  suggestAlternative: "entrance=main";
+  group: tr("deprecated tagging");
+}
 
 /* When tags are deprecated they should be added to ignoretags.cfg too. */

resources/data/validator/ignoretags.cfg

@@ -725 +725 @@
 E:pump:type
 K:substance=heat
 K:surface=decoturf
+K:school=entrance
 ;
 ; Tags not yet decided (to remove from this section when added or moved up when deprecated) 
 ; see josm tickets: 17770 15309 15774 16315 16658 16793 19982

With ​https://wiki.openstreetmap.org/wiki/Proposed_features/Key:school%3Dentrance#Rationale voting finished. I'll give other maintainers a chance to look at the changes, and I'll apply it Monday (if I forget, feel free to ping the ticket on Tuesday).

[anonymous]

Great! Thanks for the follow-up.

[taylor.smock]

In 18524/josm:

Fix #22120: Add 'school=entrance' to deprecation warnings

The number of school=entrance tags reached its peak in 2014 (1),
and has since started to see a decrease in usage. At its height,
there were about 1,700 uses of school=entrance.

(1) ​taginfo:tags/school=entrance#chronology