#22048 closed enhancement (fixed)
[Patch] building=construction preset missing some values
| Reported by: | aceman | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 22.07 |
| Component: | Internal preset | Version: | |
| Keywords: | building construction | Cc: |
Description
Hi. JOSM recently got the preset for building=construction and then there is a field listing some values for the 'construction' key. But not all values from 'building' keys in JOSM presets are included in this list. Most notably the values from preset 'unspecified residential building' are missing, like "apartments", "hotel", "detached".
Attachments (1)
Change History (13)
comment:1 by , 3 years ago
| Keywords: | building construction added |
|---|---|
| Type: | defect → enhancement |
| Version: | latest |
comment:2 by , 3 years ago
It would be best to use all those values that are already in the JOSM presets, to pick up all translations automatically.
And I do get building=detached offered in an JOSM preset (including translation). Unless it comes from some plugin:)
Anyway, as it is one of the most popular values, so it definitely should be in the presets (for constructed and in-construction buildings).
comment:3 by , 3 years ago
Sorry, I mixed up detached and semi-detached. The first is in defaultpresets.
I am not sure anymore, where I got the values from. By chance, I missed the value for residential buildings and the general values like industrial or commercial.
Can we create a list of the most important values which are missing?
comment:4 by , 3 years ago
| Milestone: | → 22.08 |
|---|---|
| Summary: | building=construction preset missing some values → [Patch] building=construction preset missing some values |
follow-up: 6 comment:5 by , 3 years ago
Stupid question: did you intend to leave out yes? It doesn't add much value, but I figured I'd better check.
comment:6 by , 3 years ago
Replying to taylor.smock:
Stupid question: did you intend to leave out
yes? It doesn't add much value, but I figured I'd better check.
Yes, building=constuction plus construction=yes does not make sense in my eyes. construction=yes is better used without *=construction, e.g. for minor constructions or for tags which do not have a *=construction, e.g. amenity, leisure, man_made …
comment:7 by , 3 years ago
OK. Looks good to me. Do you want me to apply it to the 22.07 milestone instead of 22.08? I'm going to do a release on July 30th, and you aren't changing any translations.
comment:8 by , 3 years ago
| Milestone: | 22.08 → 22.07 |
|---|
Please, go ahead. I forgot that all values are already translated.
comment:11 by , 3 years ago
Nothing really -- I just sorted the values. The only two that changed position were house (moved before hospital) and digester (moved before detached). I didn't think it was worth asking you to change the patch, since I had already sorted them.
I used most common values from taginfo.
Regarding
detached, the value is not in presets forbuilding=*, atm.