Opened 3 years ago
#21832 new enhancement
Complain about disused:shop with opening_hours
| Reported by: | mkoniecz | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- load map data for https://www.openstreetmap.org/way/289091544#map=19/52.22897/21.00178
- run validator
What is the expected result?
JOSM complain about opening_hours on disused:shop
The same would prefer to other lifecycle prefixes, but other are much less popular - see https://taginfo.openstreetmap.org//search?q=%3Ashop
http://overpass-turbo.eu/?q=LyoKVGhpcyBoYcSGYmVlbiBnxI1lcmF0ZWQgYnkgdGhlIG92xJJwxIlzLXR1cmJvIHdpemFyZC7EgsSdxJ9yaWdpbmFsIHNlxLBjaMSsxIk6CsOiwoDCnCJkxIV1xL9kOnNob3AiPSogYW7El8WUxI3EumdfxZPEqHPFl8SPbG9ixLzFiMKdCiovCltvdXQ6anNvbl1bdGltZcWyxbQyNTAwXTsKLy_Ej8SUxJ1yIHJlc3VsdHMKKAogIMaJIHF1xJLEmsSjcnQgZm9yOiDFiMWKxYzGksWPxZHFk8WVxaXFmsWccMWebsWgxaJyxaQqxavGmSBub2RlW8WLxY3Gr8WSxZQixboixZ1uxZ_FocWyxrvHi8aHxpp3YXnHhcatxY7Elsawx4rHjMeOx5DGunPHlMa_xpBsxJRpxbjHmseHx53HicWVx6DGtsePxrjHkcWjx6UpxofGnHDEt27GpMaQxpLGlMaWxoAgY8Wyx707&c=BSSF-DMfZM reports 1800 cases, so apparently it is typical that people marking shop as disused forget to remove opening_hours
What happens instead?
No complaints.
Please provide any additional information below. Attach a screenshot if possible.
Triggered by https://github.com/streetcomplete/StreetComplete/pull/3719
(is it possible to have social facility in disused shop? Maybe exclude places with shop or amenity tags)
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022)
Revision:18360
Build-Date:2022-01-02 20:26:19
URL:https://josm.openstreetmap.de/svn/trunk
Identification: JOSM/1.5 (18360 en) Linux Ubuntu 20.04.3 LTS
Memory Usage: 502 MB / 3974 MB (282 MB allocated, but free)
Java version: 11.0.13+8-Ubuntu-0ubuntu1.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00) :0.1 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.13+8-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found
Plugins:
+ buildings_tools (35893)
+ measurement (35893)
+ reverter (35893)
+ todo (30306)
Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss
Last errors/warnings:
- 00003.666 W: Update plugins - Last plugin update more than 33 days ago.
- 00013.558 W: Failed to add ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss to tag checker
- 00013.558 W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss
