Modify ↓

Opened 3 years ago

Closed 3 years ago

#21736 closed defect (fixed)

[Patch] False positive: "oneway=yes together with lanes:backward/forward" together with oneway:*

Reported by: skyper Owned by: team
Priority: normal Milestone: 22.02
Component: Core validator Version: tested
Keywords: template_report lanes oneway oneway:bus Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have a way with only a bus lane in opposite direction, e.g. ​api/0.6/way/706668449/17, with lanes:forward=1, oneway=yes, oneway:*=no, *((:lanes)?:forward|(:lanes)?:backward)
  2. Run validator

What is the expected result?

No warning

What happens instead?

suspicious tag combination

  • oneway=yes together with bus:lanes:backward
  • oneway=yes together with lanes:forward

Please provide any additional information below. Attach a screenshot if possible.

We should probably add [/^oneway:./!=no] to exclude these special cases.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022)
Revision:18360
Build-Date:2022-01-02 20:26:19
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (2)

josm_21736.patch​ (2.5 KB ) - added by skyper 3 years ago.
patch
josm_21736_v2.patch​ (2.6 KB ) - added by skyper 3 years ago.
version 2: stricter regex; adds oneway:mofa and oneway:moped

Download all attachments as: .zip

Change History (9)

comment:1 by skyper, 3 years ago

Summary: False possitive: "oneway=yes together with lanes:backward/forward" together with oneway:* → False positive: "oneway=yes together with lanes:backward/forward" together with oneway:*

comment:2 by skyper, 3 years ago

Description: modified (diff)

by skyper, 3 years ago

Attachment: josm_21736.patch​ added

patch

comment:3 by skyper, 3 years ago

Summary: False positive: "oneway=yes together with lanes:backward/forward" together with oneway:* → [Patch] False positive: "oneway=yes together with lanes:backward/forward" together with oneway:*

Please, find attached patch​ which adds oneway:bus as exception and enables the info warning for missing lanes:forward/backward if only one is present and oneway:bus/psv=no is tagged.

comment:4 by skyper, 3 years ago

Milestone: → 22.01

by skyper, 3 years ago

Attachment: josm_21736_v2.patch​ added

version 2: stricter regex; adds oneway:mofa and oneway:moped

comment:5 by skyper, 3 years ago

The regexs were not strict enough and I'd forgotten oneway:moped and oneway:mofa.
Version 2​ fixes these issues.

comment:6 by stoecker, 3 years ago

Milestone: 22.01 → 22.02

Milestone renamed

comment:7 by stoecker, 3 years ago

Resolution: → fixed
Status: new → closed

In 18370/josm:

fix #21736, patch by skyper, False positive: "oneway=yes together with lanes:backward/forward" together with oneway:*

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.