Allow tourism=attraction inside tourism=attraction

[mkoniecz]

What steps will reproduce the problem?

1. Scan around ​https://www.openstreetmap.org/node/6637905260 (knife replica - a minor tourism attraction - see ​https://pl.wikipedia.org/wiki/N%C3%B3%C5%BC_w_Sukiennicach_w_Krakowie that is within ​https://pl.wikipedia.org/wiki/Sukiennice_w_Krakowie - a major and larger tourism attraction)

What is the expected result?

tourism=attraction inside tourism=attraction is not getting complaints

What happens instead?

tourism=attraction inside tourism=attraction error

Please provide any additional information below. Attach a screenshot if possible.

Note that as bare tourism=attraction is never sufficient tagging actual duplicates will be detected anyway of tagged properly.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-12-21 15:17:17 +0100 (Tue, 21 Dec 2021)
Revision:18351
Build-Date:2021-12-22 02:31:06
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18351 en) Linux Ubuntu 20.04.3 LTS
Memory Usage: 632 MB / 3974 MB (278 MB allocated, but free)
Java version: 11.0.13+8-Ubuntu-0ubuntu1.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00) :0.1 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.13+8-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (35823)
+ measurement (35640)
+ reverter (35869)
+ todo (30306)

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss

Last errors/warnings:
- 00009.655 W: Failed to add ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss to tag checker
- 00009.656 W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss

[skyper]

Similar to leisure=* this can be stacked. Is the some kind off topological ranking to define a order which tourism=* is expected to enclose possible other tourism=*?

[mkoniecz]

I can imagine almost any combination for something involving tourism=attraction - most of them quite obvious but can also provide further examples.

I also suspect that there are valid tourism=museum within tourism=museum but I have no ready examples.

tourism=artwork within tourism=artwork is likely also possible.

Though tourism=hotel withing tourism=hotel should continue to be reported.

​https://taginfo.openstreetmap.org/keys/tourism#values

[skyper]

The "hack" tourism=attraction might be an exception but I am not happy with any other value inside the identical value and think, there should be a way to avoid it. Last option my be a site relation. Some real examples would be helpful.

As for some hierarchy, I thought that e.g. a tourism=resort might include some tourism=hotel/apartment/chalet/… but not the opposite way. Same is true for e.g. museum and artwork I would say.

[mkoniecz]

I expect that very large statues may have museum within - see ​https://en.wikipedia.org/wiki/List_of_tallest_statues

With base 58m high there is plenty of space to fit things.

EDIT: ​https://mainichi.jp/english/articles/20200402/p2a/00m/0na/016000c has exactly this case

The statue had an observatory just under its neck, and its five-story pedestal was an exhibition facility.

See ​https://cdn.mainichi.jp/vol1/2020/04/02/20200402p2a00m0na015000p/9.jpg?3 for an image