validator test for post_office:type=*

[leni]

With the approved proposal ​Proposed features/shop as post-partner: post_office:type=* is marked as deprecated.

It would be nice to add a validator-warning.

[skyper]

I think only deprecating is a bit shorthanded. We rather should add post_office=* to the preset. I am not sure how to handle post_office=post_partner and possible subkeys which can be added to all kinds of primary tags. Probably need an own preset without amenity=post_office but most of the other tags.

[leni]

I agree, but it seems to me that the absence of a preset does not prevent the use of `post_office=* tags in JOSM ... on the other hand, the absence of a control allows the deprecated post_office:type=* tag to continue to be used.

That's why I put this evolution on "Core validator" to limit the use of this attribute, another request for improvement could concern "Internal Preset"

[skyper]

JOSM does never prevent a tag to be used, besides some technical limits like no more than 255 characters.

In my eyes, it is a bad user experience if we warn about a deprecated tag which was never present in core and at the same time propose a new tag which is not available through presets.

Anyway, altogether should not be a big deal, besides icons and possible changes in style to support post services together with other shops. The latter is probably out of scope and needs a separate ticket.

[leni]

You are right, it is better to suspend this control, to set up the preset (I am preparing the request); then, we should see the evolution of the data (post_office:type and post_office) in the database and determine if it is necessary to set up this warning.