[PATCH] Move plugin ejml to ivy, update ejml from 0.34 to 0.41

[taylor.smock]

I'm going to be uploading two patches. The first patch should be binary compatible with the current suite of plugins (it keeps the current ejml version). I am not updating the ejml version until I get the dependent plugins onto ivy.

The second patch updates ejml from 0.34 to 0.41.

See ​https://github.com/lessthanoptimal/ejml/blob/SNAPSHOT/change.txt for the full changelog for 0.34 -> 0.41.

ejml is used by the following plugins:

• areaselector
• cadastre-fr
  • Also depends upon geotools
• geotools (non-ivy)
  • ImportImagePlugin (doesn't appear to have libs in tree)
  • Tracer-testing (tracer/tracer2 didn't appear to have libs in tree)
  • cadastre-fr (nothing needed)
  • matsim (gradle)
  • opendata (non-ivy)

[taylor.smock]

Update ejml from 0.34 to 0.41 (depends upon attachment:21669.patch​)

[Don-vip]

In 35883/osm:

see #21669 - Move plugin ejml to ivy

[Don-vip]

In 35885/osm:

see #21669 - Upgrade to EJML 0.41

[Mkyral]

Hi,
Tracer-testing author there ;-)

After latest update of all plugins, LPIS module of tracer-testing stopped working. It generates no exception, action just silently die on this row:
​https://github.com/mkyral/josm-tracer/blob/development/src/org/openstreetmap/josm/plugins/tracer/modules/lpis/krovak.java#L128

JOSM still works, as well as other tracer-testing modules. Only this LPIS module, where I need transformation from/to krovak CRS, does nothing.

I have no idea what is wrong and if it could be connected with this change, or it is something else.

[Mkyral]

Update,
when I use old ejml.jar from backup, everything works as expected. Could this be an incompatibility with older geotools?

[Mkyral]

Last working version is EJML 0.39.

[taylor.smock]

Replying to Mkyral:

Update,
when I use old ejml.jar from backup, everything works as expected. Could this be an incompatibility with older geotools?

Definitely a possibility. I haven't gotten around to updating/touching geotools, but recompiling it and tracer2 might fix the problem.

[Mkyral]

I've compiled latest geotools (26.1) and it does not work either. Also I've found this open issue:
​https://osgeo-org.atlassian.net/browse/GEOT-6384 (Upgrade EJML to 0.38) - so it was probably not upgraded to v0.38 yet.

In ejml changelog is this in 0.40 part:

• Strictly enforce usage of @Nullable to public API
  • ​https://github.com/uber/NullAway
  • Private class fields mostly have NullAway disabled because it doesn't model how they are coupled resulting in pointlessly verbose code

…

• CommonOps_DDRM and CommonOps_DSCC
  • Updating functions to return output if null and use common input sanity check functions
• CommonOps_DSCC
  • duplicatesAdd() is a function which will add elements that are duplicated, turning it into a valid matrix again
  • Removed the functions below since they had a runtime complexity of O(N^{2) relative to matrix size instead of O(N)}
    • multTransA(S,S,S), multTransB(S,S,S), innerProductLower(S,S,S)
    • Thanks Florentin Dörre for first noticing the performance issue