Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21655 closed defect (fixed)

Wrong order of changesets in the changeset manager

Reported by: andre-sa Owned by: Don-vip
Priority: normal Milestone: 21.12
Component: Core Version: tested
Keywords: template_report changeset Cc:

Description

What steps will reproduce the problem?

  1. Open changeset manager (and take note of the changesets in the default order);
  2. Order the changesets by another column (e.g. Discussions, or Changes);
  3. Select the first or second changeset of the list;
  4. Notice it's the first or second changeset of the original list, with the default order.

What is the expected result?

After changing the order according to some other column other than the default, selecting a row should select the displayed changeset.

What happens instead?

After changeing the order according to some other column other than the default, selecting a row selects the changeset that was on that row originally, with the default order.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-01 23:05:46 +0100 (Mon, 01 Nov 2021)
Revision:18303
Build-Date:2021-11-01 22:25:18
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18303 en) Linux Debian GNU/Linux bookworm/sid
Memory Usage: 1478 MB / 8000 MB (666 MB allocated, but free)
Java version: 11.0.13+8-post-Debian-1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.nimbus.NimbusLookAndFeel
Screen: :0.0 2560×1440 (scaling 1.00×1.00) :0.1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: DWM
Java package: openjdk-11-jre:amd64-11.0.13+8-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35640)
+ apache-commons (35524)
+ ejml (35458)
+ geotools (35458)
+ imagery_offset_db (35640)
+ jaxb (35543)
+ jts (35458)
+ notesolver (0.3.3)
+ opendata (35803)
+ utilsplugin2 (35856)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/PT.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/Portuguese-Specific&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/Portuguese-Errors-PT2&zip=1

Last errors/warnings:
- 00008.044 W:  Tunnel: Could not get presets icon traffic_signs_presets/tunnel.png
- 00954.375 W: java.io.IOException: Tags to paste are not valid.
- 00955.635 W: java.io.IOException: Tags to paste are not valid.
- 165606.812 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- 171216.025 W: Nothing to zoom to - <html>None of the objects in the content of changeset 110 733 362 is available in the current<br>edit layer 'Data Layer 1'.</html>
- 267903.005 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=9312614401 version=1 VT lat=41.5604831,lon=-8.4088626}
- 267997.497 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=9312614401 version=1 VT lat=41.5604831,lon=-8.4088626}
- 268001.594 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=9312614401 version=1 VT lat=41.5604831,lon=-8.4088626}
- 268224.330 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=9312614401 version=1 VT lat=41.5604831,lon=-8.4088626}
- 268878.785 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=9312614401 version=1 VT lat=41.5604831,lon=-8.4088626}

Attachments (2)

josm-chsetmngr-default.png (216.9 KB ) - added by andre-sa 3 years ago.
Changeset Manager, default order
josm-chsetmngr-changes.png (213.8 KB ) - added by andre-sa 3 years ago.
Changeset Manager, ordered by "Changes"

Download all attachments as: .zip

Change History (9)

by andre-sa, 3 years ago

Attachment: josm-chsetmngr-default.png added

Changeset Manager, default order

by andre-sa, 3 years ago

Attachment: josm-chsetmngr-changes.png added

Changeset Manager, ordered by "Changes"

comment:1 by andre-sa, 3 years ago

Notice that in both screenshots the second changeset of the list is selected, but in both cases "Store no longer exists (...)" is shown on the bottom window.

comment:2 by Don-vip, 3 years ago

Keywords: changeset added

comment:3 by Don-vip, 3 years ago

Milestone: 21.12
Owner: changed from team to Don-vip
Status: newassigned

comment:4 by skyper, 3 years ago

Duplicate of #19984?

comment:5 by Don-vip, 3 years ago

Resolution: fixed
Status: assignedclosed

In 18338/josm:

fix #21655 - fix selection of changesets after sorting the table

comment:6 by Don-vip, 3 years ago

In 18344/josm:

see #21655 - update unit test

comment:7 by Don-vip, 3 years ago

Ticket #19984 has been marked as a duplicate of this ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.