Delete key only works every second time in the ToDo plugin

[nkamapper]

What steps will reproduce the problem?

1. Add a number of map elements to the To-do window
2. Click Mark button in the To-do window
3. Press Delete button on keyboard

4.. Press Next and repeat 2-3 with the next items in the To-do window

What is the expected result?

Each item should be deleted when the Delete key is pressed

What happens instead?

Only every second item is deleted, i.e. the Delete key works every second time Next is pressed in the ToDo-window.

Please provide any additional information below. Attach a screenshot if possible.

The various items are displayed in the Selection window as the single element after each Mark.
Selecting the Delete function in the Edit menu works, but not the Delete button on the keyboard.
This has been a problem for a few years.
Tested on Mac.

Revision:18193
Build-Date:2021-09-05 16:25:52

Identification: JOSM/1.5 (18193 en_GB) Mac OS X 10.13.6
OS Build number: Mac OS X 10.13.6 (17G14042)
Memory Usage: 486 MB / 4096 MB (83 MB allocated, but free)
Java version: 16.0.2+7, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69676352 2560×1440 (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=18193, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM]

Plugins:
+ Mapillary (2.0.0-alpha.36-dirty)
+ PicLayer (1.0.1)
+ SeaChart (35840)
+ apache-commons (35524)
+ apache-http (35589)
+ conflation (0.6.6)
+ ejml (35458)
+ geotools (35458)
+ imagery-xml-bounds (35723)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ opendata (35803)
+ pdfimport (35640)
+ reverter (35846)
+ tageditor (35640)
+ todo (30306)
+ turnlanes (35812)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)
+ utilsplugin2 (35856)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- http://osm.wzh.be/josm/different_buildings/different_buildings.mapcss

[taylor.smock]

What delete button?

Maybe you mean the Mark button?

[nkamapper]

Replying to taylor.smock:

What delete button?

The delete key on the keyboard or the delete function in the JOSM menu (with the aim of deleting the object which has been selected when pressing the Next button in the Todo-window).

[taylor.smock]

This has been working for me. Caveat: I'm using a dev version with some additional changes. I'm planning on doing a release for it next week (to give translators a chance to update their translations).

[nkamapper]

I tested again today with version 18622. The Delete key now does not work every second time after the Next button has been used.

[taylor.smock]

I haven't been able to reproduce. I think we have a communication problem here, and I'm thinking you are doing something that you are not.

Can you upload a gif/video showing the behavior?

Also, can you add an updated status report? See BadReport for instructions if you don't know how to get the status report.

[nkamapper]

Here is a video: ​https://www.jottacloud.com/s/05997e2ea64341942aa9da453213b7da029

[taylor.smock]

Thanks. It looks like it is probably a case of the Todo dialog window having keyboard focus, instead of the map view.

[nkamapper]

Updated bug report:

Revision:18622
Build-Date:2023-01-04 13:00:15

Identification: JOSM/1.5 (18622 en_GB) Mac OS X 12.6.1
OS Build number: macOS 12.6.1 (21G217)
Memory Usage: 726 MB / 4096 MB (340 MB allocated, but free)
Java version: 17.0.5+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69733568 1440×900 (scaling 2.00×2.00)
Maximum Screen Size: 1440×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=18622, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM]
Dataset consistency test: No problems found

Plugins:
+ PicLayer (1.0.2)
+ apache-commons (36034)
+ apache-http (35924)
+ changeset-viewer (0.0.6)
+ conflation (0.6.9)
+ ejml (35924)
+ ext_tools (35893)
+ geotools (36028)
+ imagery-xml-bounds (35976)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36034)
+ opendata (36025)
+ pdfimport (35976)
+ reverter (36043)
+ todo (30306)
+ utilsplugin2 (36011)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

[taylor.smock]

This is going to be a PITA to debug.

What I've found so far:

• The LayerListDialog object is where the key binding for delete is getting processed when the delete button works, and is not checked when the delete button does not work. (breakpoint set in DeleteAction#actionPerformed)
• The condition is JComponent.WHEN_IN_FOCUSED_WINDOW in JComponent#processKeyBinding, pressed is true.