Context Navigation

Modify ↓

#21511 closed defect (duplicate)

[PATCH] Areaselector don't work with JOSM

Reported by:	SafetyIng	Owned by:	team
Priority:	normal	Milestone:
Component:	Plugin areaselector	Version:
Keywords:	template_report	Cc:

Description

What steps will reproduce the problem?

Start area-selector
Click on an area
Become Error

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Revision:18307
Is-Local-Build:true
Build-Date:2021-11-03 14:00:03

Identification: JOSM/1.5 (18307 SVN de) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 1459 MB / 2020 MB (225 MB allocated, but free)
Java version: 17.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.25×1.25) \Display1 1920×1080 (scaling 1.25×1.25)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18303, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35640)
+ areaselector (368)
+ austriaaddresshelper (1597341117)
+ buildings_tools (35823)
+ ejml (35458)
+ gridify (1606242219)
+ imagery_offset_db (35640)
+ log4j (35458)
+ pt_assistant (1ff2e15)
+ reverter (35732)
+ shrinkwrap (v1.0.4)
+ tageditor (35640)
+ terracer (35827)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35842)

Tagging presets:
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Healthcare&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewParkingFeatures&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
- https://raw.githubusercontent.com/yopaseopor/indoormap/master/indoormap-style.mapcss
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- <josm.pref>\styles\sit.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- 00000.675 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.679 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00003.004 E: java.security.KeyStoreException: Windows-ROOT not found. Ursache: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00004.932 W: Erweiterungen aktualisieren - Sie haben JOSM aktualisiert. Zur Vermeidung von Problemen sollten die Erweiterungen ebenfalls aktualisiert werden.  Erweiterungen jetzt aktualisieren?
- 00037.992 E: Fehler beim Laden des Bildes 'bus.png'
- 00063.866 W: Es konnte keine unterstützte Projektion für Ebene LVermGeo 20cm gefunden werden. Verwende EPSG:3857.
- 00063.867 W: Es konnte keine unterstützte Projektion für Ebene LVermGeo 20cm gefunden werden. Verwende EPSG:3857.
- 00063.892 W: Es konnte keine unterstützte Projektion für Ebene Hausumrisse LVERMGEO gefunden werden. Verwende EPSG:3857.
- 00063.893 W: Es konnte keine unterstützte Projektion für Ebene Hausumrisse LVERMGEO gefunden werden. Verwende EPSG:3857.
- 00284.453 E: Handled by bug report queue: java.lang.IllegalAccessError: class boofcv.io.image.ConvertBufferedImage (in unnamed module @0x724990d9) cannot access class sun.awt.image.ByteInterleavedRaster (in module java.desktop) because module java.desktop does not export sun.awt.image to unnamed module @0x724990d9



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (23) of main
java.lang.IllegalAccessError: class boofcv.io.image.ConvertBufferedImage (in unnamed module @0x724990d9) cannot access class sun.awt.image.ByteInterleavedRaster (in module java.desktop) because module java.desktop does not export sun.awt.image to unnamed module @0x724990d9
	at boofcv.io.image.ConvertBufferedImage.convertFrom(ConvertBufferedImage.java:319)
	at org.openstreetmap.josm.plugins.areaselector.ImageAnalyzer.detectCannyArea(ImageAnalyzer.java:690)
	at org.openstreetmap.josm.plugins.areaselector.ImageAnalyzer.getArea(ImageAnalyzer.java:151)
	at org.openstreetmap.josm.plugins.areaselector.AreaSelectorAction.createArea(AreaSelectorAction.java:197)
	at org.openstreetmap.josm.plugins.areaselector.AreaSelectorAction$1.run(AreaSelectorAction.java:150)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)

Attachments (0)

Change History (15)

comment:1 by taylor.smock, 3 years ago

Is-Local-Build:true

I doubt this is accurate, but if you built JOSM yourself, please try doing ant clean dist.

But realistically, you are probably running JOSM under OpenWebStart.

java.lang.IllegalAccessError: class boofcv.io.image.ConvertBufferedImage (in unnamed module @0x724990d9) cannot access class sun.awt.image.ByteInterleavedRaster (in module java.desktop) because module java.desktop does not export sun.awt.image to unnamed module @0x724990d9

I'll take a look at updating the boofcv libraries in the plugin. It is currently using v0.24.1 (2016-06) with the latest version being v0.39.1. v0.39.1 dropped Java 8 support, so the latest version we can use is v0.39.0. Hopefully it "just works" in Java 17.

See https://github.com/lessthanoptimal/BoofCV/issues/62 . See also https://github.com/JOSM/areaselector/issues/43 .

comment:2 by taylor.smock, 3 years ago

Priority:	critical → normal

comment:3 by Don-vip, 3 years ago

Resolution:	→ duplicate
Status:	new → closed

Closed as duplicate of #21226.

comment:4 by taylor.smock, 3 years ago

Summary:	Areaselector don't work with JOSM → [PATCH] Areaselector don't work with JOSM

I've made a PR at https://github.com/JOSM/areaselector/pull/45

follow-up: 6 comment:5 by Don-vip, 3 years ago

More work is needed to get a release:

Buildfile: C:\SVN\josm\plugins\areaselector\build.xml
clean:
   [delete] Deleting directory C:\SVN\josm\plugins\areaselector\build
   [delete] Deleting directory C:\SVN\josm\plugins\areaselector\javadoc
   [delete] Deleting: C:\SVN\josm\dist\areaselector.jar
   [delete] Deleting: C:\SVN\josm\dist\areaselector-sources.jar
   [delete] Deleting: C:\SVN\josm\dist\areaselector-javadoc.jar
init:
    [mkdir] Created dir: C:\SVN\josm\plugins\areaselector\build
...
compile:
     [echo] compiling sources for C:\SVN\josm\dist\areaselector.jar ...
    [javac] Compiling 16 source files to C:\SVN\josm\plugins\areaselector\build
    [javac] Support for javac --release has been added in Java9 ignoring it
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:45: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac] import org.openstreetmap.josm.gui.tagging.ac.AutoCompletingComboBox;
    [javac]                                             ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:85: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected AutoCompletingComboBox streetNameField, cityField, postCodeField, countryField, houseNameField, buildingField, tagsField, sourceField;
    [javac]               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:85: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected AutoCompletingComboBox streetNameField, cityField, postCodeField, countryField, houseNameField, buildingField, tagsField, sourceField;
    [javac]               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:85: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected AutoCompletingComboBox streetNameField, cityField, postCodeField, countryField, houseNameField, buildingField, tagsField, sourceField;
    [javac]               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:85: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected AutoCompletingComboBox streetNameField, cityField, postCodeField, countryField, houseNameField, buildingField, tagsField, sourceField;
    [javac]               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:85: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected AutoCompletingComboBox streetNameField, cityField, postCodeField, countryField, houseNameField, buildingField, tagsField, sourceField;
    [javac]               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:85: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected AutoCompletingComboBox streetNameField, cityField, postCodeField, countryField, houseNameField, buildingField, tagsField, sourceField;
    [javac]               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:85: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected AutoCompletingComboBox streetNameField, cityField, postCodeField, countryField, houseNameField, buildingField, tagsField, sourceField;
    [javac]               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:85: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected AutoCompletingComboBox streetNameField, cityField, postCodeField, countryField, houseNameField, buildingField, tagsField, sourceField;
    [javac]               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:128: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]         houseNameField = new AutoCompletingComboBox();
    [javac]                              ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:129: error: cannot find symbol
    [javac]         houseNameField.setPossibleAcItems(acm.getTagValues(TAG_HOUSENAME));
    [javac]                       ^
    [javac]   symbol:   method setPossibleAcItems(AutoCompletionSet)
    [javac]   location: variable houseNameField of type AutoCompletingComboBox
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:180: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]         streetNameField = new AutoCompletingComboBox();
    [javac]                               ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:181: error: cannot find symbol
    [javac]         streetNameField.setPossibleAcItems(acm.getTagValues(TAG_STREETNAME));
    [javac]                        ^
    [javac]   symbol:   method setPossibleAcItems(AutoCompletionSet)
    [javac]   location: variable streetNameField of type AutoCompletingComboBox
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:185: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]         cityField = new AutoCompletingComboBox();
    [javac]                         ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:186: error: cannot find symbol
    [javac]         cityField.setPossibleAcItems(acm.getTagValues(TAG_CITY));
    [javac]                  ^
    [javac]   symbol:   method setPossibleAcItems(AutoCompletionSet)
    [javac]   location: variable cityField of type AutoCompletingComboBox
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:190: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]         postCodeField = new AutoCompletingComboBox();
    [javac]                             ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:191: error: cannot find symbol
    [javac]         postCodeField.setPossibleAcItems(acm.getTagValues(TAG_POSTCODE));
    [javac]                      ^
    [javac]   symbol:   method setPossibleAcItems(AutoCompletionSet)
    [javac]   location: variable postCodeField of type AutoCompletingComboBox
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:195: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]         countryField = new AutoCompletingComboBox();
    [javac]                            ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:196: error: cannot find symbol
    [javac]         countryField.setPossibleAcItems(acm.getTagValues(TAG_COUNTRY));
    [javac]                     ^
    [javac]   symbol:   method setPossibleAcItems(AutoCompletionSet)
    [javac]   location: variable countryField of type AutoCompletingComboBox
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:201: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]         buildingField = new AutoCompletingComboBox();
    [javac]                             ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:202: error: cannot find symbol
    [javac]         buildingField.setPossibleAcItems(acm.getTagValues(TAG_BUILDING));
    [javac]                      ^
    [javac]   symbol:   method setPossibleAcItems(AutoCompletionSet)
    [javac]   location: variable buildingField of type AutoCompletingComboBox
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:229: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]         tagsField = new AutoCompletingComboBox();
    [javac]                         ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:230: error: cannot find symbol
    [javac]         tagsField.setPossibleAcItems(aciTags);
    [javac]                  ^
    [javac]   symbol:   method setPossibleAcItems(Collection<AutoCompletionItem>)
    [javac]   location: variable tagsField of type AutoCompletingComboBox
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:234: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]         sourceField = new AutoCompletingComboBox();
    [javac]                           ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:249: error: cannot find symbol
    [javac]         sourceField.setPossibleAcItems(sourceValues);
    [javac]                    ^
    [javac]   symbol:   method setPossibleAcItems(AutoCompletionSet)
    [javac]   location: variable sourceField of type AutoCompletingComboBox
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:284: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]             if (field instanceof AutoCompletingComboBox){
    [javac]                                  ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:285: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]                 AutoCompletingComboBox combox = (AutoCompletingComboBox) field;
    [javac]                 ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:285: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]                 AutoCompletingComboBox combox = (AutoCompletingComboBox) field;
    [javac]                                                  ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:331: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]                     } else if (fields.get(i) instanceof AutoCompletingComboBox) {
    [javac]                                                         ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:332: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]                         AutoCompletingComboBox ac = (AutoCompletingComboBox) fields.get(i);
    [javac]                         ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:332: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]                         AutoCompletingComboBox ac = (AutoCompletingComboBox) fields.get(i);
    [javac]                                                      ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:353: warning: [deprecation] AutoCompletingComboBox in org.openstreetmap.josm.gui.tagging.ac has been deprecated
    [javac]     protected String getAutoCompletingComboBoxValue(AutoCompletingComboBox box) {
    [javac]                                                     ^
    [javac] C:\SVN\josm\plugins\areaselector\src\org\openstreetmap\josm\plugins\areaselector\ImageAnalyzer.java:1106: error: cannot find symbol
    [javac]         ConsoleAppender console = ConsoleAppender.newBuilder().setName("console").setLayout(
    [javac]                                                               ^
    [javac]   symbol:   method setName(String)
    [javac]   location: class Builder<B>
    [javac]   where B is a type-variable:
    [javac]     B extends Builder<B>
    [javac] 9 errors
    [javac] 24 warnings

Old combobox APIs are still used and must be upgraded
It seems a new log4j API is used, our log4j plugin should probably be upgraded (and switched from plain old jar files to new Ivy system)

in reply to: 5 comment:6 by taylor.smock, 3 years ago

Replying to Don-vip:

More work is needed to get a release:
[snip]
Old combobox APIs are still used and must be upgraded
It seems a new log4j API is used, our log4j plugin should probably be upgraded (and switched from plain old jar files to new Ivy system)

Oops -- I was using the gradle build script. I'll look into updating the combobox usages tomorrow. And I'll take a look at log4j tomorrow as well (as in move areaselect to the log4j plugin instead of bundling its own).

EDIT: log4j plugin update: #21517
EDIT2: areaselector update: https://github.com/JOSM/areaselector/pull/46

Last edited 3 years ago by taylor.smock (previous) (diff)

comment:7 by taylor.smock, 3 years ago

@Don-vip: I don't think we ever did a dist.

comment:8 by taylor.smock, 3 years ago

Ticket #21795 has been marked as a duplicate of this ticket.

comment:9 by taylor.smock, 3 years ago

@Don-vip: Can we do a release for this?

follow-up: 11 comment:10 by stoecker, 3 years ago

What about copying the code back to SVN and use established build mechanism? Seems nobody really cares for the GitHub code.

Last edited 3 years ago by stoecker (previous) (diff)

in reply to: 10 ; follow-up: 15 comment:11 by taylor.smock, 3 years ago

Replying to stoecker:

What about copying the code back to SVN and use established build mechanism? Seems nobody really cares for the GitHub code.

I'm open to that, at least for anything not actively maintained. But my opinion really doesn't matter for this. :)

Personally, I use GitLab and largely ignore GitHub (I let mirroring take care of updating the GitHub version). But I don't think https://gitlab.com/josm is controlled by any of the core maintainers.

EDIT: Or we could just do the release process in SVN.

Last edited 3 years ago by taylor.smock (previous) (diff)

comment:12 by anonymous, 3 years ago

Taylor, thanks for all your help in various commits and comments getting this plugin working, again.

comment:13 by Don-vip, 3 years ago

Done: https://github.com/JOSM/areaselector/releases/tag/v2.6.0

comment:14 by anonymous, 3 years ago

Thanks. I can confirm that the updated plugin works with JOSM 18360.

in reply to: 11 comment:15 by stoecker, 3 years ago

Replying to taylor.smock:

I'm open to that, at least for anything not actively maintained. But my opinion really doesn't matter for this. :)

Well, that's surely untrue. For JOSM the rule simply is "who does the work also decides" and you do a lot of work, so naturally your opinion counts.

EDIT: Or we could just do the release process in SVN.

The plugin SVN is maybe old-style, but easy to handle for multiple plugins. The GitHub repos are convenience for nowadays GitHub-affine programmers. When there are no more of these moving it back is not out of scope.

Modify Ticket

Change Properties

Summary:
Type:		Priority:
Milestone:		Component:
Version:		Keywords:
Cc:	Set your email in Preferences

Action

leave as closed The owner will remain team.

change resolution as The resolution will be set.

reopen The resolution will be deleted. Next status will be 'reopened'.

Add Comment

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.

Download in other formats: