Modify

Opened 3 years ago

Closed 3 years ago

#21477 closed defect (fixed)

OpenQA: Doesn't automerge new objects

Reported by: BalooUriza Owned by: taylor.smock
Priority: normal Milestone:
Component: Plugin openqa Version:
Keywords: download merge Cc:

Description

When downloading more OSM data, OpenQA does correctly fetch new objects, but requires a right-click > Clear after download to avoid potentially long lists of duplicates.

Attachments (0)

Change History (10)

comment:1 by skyper, 3 years ago

Component: CorePlugin ​openqa
Keywords: download merge added
Owner: changed from team to taylor.smock

comment:2 by taylor.smock, 3 years ago

Keywords: download merge removed

I really need to redo the download logic. IIRC, I just took the download area of the bounding box and got the data in that area.
I should probably switch to tile-based requests.

TBH, I don't know when I'll have time to fix this issue, but I'll see if I can work this in sometime this year.

comment:3 by skyper, 3 years ago

Keywords: download merge added

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

  • The required parts of the Status Report from your JOSM.
  • Describe what behaviour you expected.
  • Describe what did happen instead.
  • Describe if and how the issue is reproducible.
  • Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Helpsource:trunk/resources/images/bug.svg Report Bug.

Remember: This is a generic notice so we don't need to write the same stuff again and again. It may only apply in parts to the specific case!


comment:4 by BalooUriza, 3 years ago

Taylor, did you need more information as suggested by Skyper, or did you understand what I mean?

in reply to:  4 comment:5 by taylor.smock, 3 years ago

Replying to BalooUriza:

Taylor, did you need more information as suggested by Skyper, or did you understand what I mean?

It would be useful, but I don't think I need it for this specific bug. Like I said in my post, "IIRC, I just took the download area of the bounding box and got the data in that area." This means that overlapping download areas would duplicate issues. Tiling the requests would probably be the easiest way to avoid duplicating issues. I'll just need to check and see what size tiles make sense. Or if there is a vector tile layer available that I could reuse.

All that being said, there is a reason why skyper asked for it -- sometimes, there are bugs specific to some random Java versions, or the operating system, or the desktop environment.

comment:6 by BalooUriza, 3 years ago

Fair. I think the quick and dirty interim fix would be to automatically "clear" after pulling data in. The potential drawbacks would be somewhat slower performance and larger memory usage before the clear, but it would at least make it compliant for doing something else without having to check on it when downloading along a very long road or powerline or whatever.

comment:7 by skyper, 3 years ago

It is always nice to have at least the Josm and the plugin version. Reporting defects without status report is a bad habit, especially, as there is an action available which gathers the information.

Last edited 3 years ago by skyper (previous) (diff)

comment:8 by Klumbumbus, 3 years ago

Resolution: fixed
Status: newclosed

In 18326/josm:

(The changeset message doesn't reference this ticket)

comment:9 by Klumbumbus, 3 years ago

Resolution: fixed
Status: closedreopened

sorry for the noise, typo in ticket number

comment:10 by taylor.smock, 3 years ago

Resolution: fixed
Status: reopenedclosed

It turns out KeepRight was being deduplicated while Osmose was not -- I was depending upon numeric error ids for that originally.

Anyway, this should be fixed in the next OpenQA release. Which should be sometime today.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain taylor.smock.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.