Modify ↓

Opened 3 years ago

Closed 3 years ago

#21469 closed enhancement (fixed)

[PATCH] First/Last buttons in image display window should remember which images they come from

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 21.10
Component: Core image mapping Version:
Keywords: Cc:

Description

When I first changed the Mapillary image viewing window to be similar to JOSM's, prior to replacing it this month, one of the feedback items I got was "I accidentally pressed first/last, and couldn't figure out where I was".

What the attached patch does:

  • Fixes an issue where non-deletable/removable objects did not disable the delete buttons
  • Adds a property change listener for actions so that the button they are part of is updated when the action is enabled/disabled
  • Adds some super classes (ImageAction/ImageRememberAction) to de-duplicate some code.
  • Attempts to keep the behavior from setNextEnabled/setPreviousEnabled intact as much as possible

Attachments (3)

21469.patch​ (20.5 KB ) - added by taylor.smock 3 years ago.
Remember last image selected for first/last buttons
21469.2.patch​ (20.6 KB ) - added by taylor.smock 3 years ago.
Fix NPE
21469.mapillary.patch​ (1.7 KB ) - added by taylor.smock 3 years ago.
Mapillary specific patch, so I don't lose/forget it

Download all attachments as: .zip

Change History (7)

by taylor.smock, 3 years ago

Attachment: 21469.patch​ added

Remember last image selected for first/last buttons

comment:1 by taylor.smock, 3 years ago

Summary: [PATCH] First/Last buttons in image display window should remember which images they come from → [WIP PATCH] First/Last buttons in image display window should remember which images they come from

comment:2 by taylor.smock, 3 years ago

Summary: [WIP PATCH] First/Last buttons in image display window should remember which images they come from → [PATCH] First/Last buttons in image display window should remember which images they come from

by taylor.smock, 3 years ago

Attachment: 21469.2.patch​ added

Fix NPE

by taylor.smock, 3 years ago

Attachment: 21469.mapillary.patch​ added

Mapillary specific patch, so I don't lose/forget it

comment:3 by Don-vip, 3 years ago

Milestone: → 21.10

comment:4 by Don-vip, 3 years ago

Resolution: → fixed
Status: new → closed

In 18290/josm:

fix #21469 - Make First/Last buttons in image display window remember which images they come from (patch by taylor.smock):

  • Fixes an issue where non-deletable/removable objects did not disable the delete buttons
  • Adds a property change listener for actions so that the button they are part of is updated when the action is enabled/disabled
  • Adds some super classes (ImageAction/ImageRememberAction) to de-duplicate some code.
  • Attempts to keep the behavior from setNextEnabled/setPreviousEnabled intact as much as possible

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.