MapWithAi "Merge address nodes and buildings" not working as expected

[timothee.duhamel@…]

What steps will reproduce the problem?

1. Using MapWithAI plugin to import buildings into OSM. (New Zealand Buildings dataset)
2. Address nodes are already present in OSM data, but I prefer NOT to merge the incoming buildings with the address nodes.
3. In the MapWithAI settings, I unselect the "Merge address nodes and buildings" option
4. I use the MapWithAI interface to add a building to my OSM data layer

What is the expected result?

I expect the building to be added to OSM data layer, without merging with the address point at that location

What happens instead?

The building is added to the OSM layer, and merges with an existing address point, when it is overlapping a single node.

Please provide any additional information below. Attach a screenshot if possible.

I've also noticed that the "Merge address nodes and buildings" option does not 'stick'. When I re-start JOSM, the setting is always set to true. Whereas other options such as 'maximum number of features', retain their value if I change it.
I will try attach OpenWebStart JOSM log file to this ticket.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Revision:18193
Build-Date:2021-09-03 01:31:19
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18193 en) Windows 10 64-Bit
OS Build number: Windows 10 Enterprise 1803 (17134)
Memory Usage: 305 MB / 4058 MB (121 MB allocated, but free)
Java version: 11.0.10+9-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.50×1.50) \Display1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_NZ
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-alpha.36-dirty)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35823)
+ contourmerge (v0.1.8)
+ jna (35662)
+ mapwithai (1.8.6)
+ reverter (35732)
+ utilsplugin2 (35792)

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1

Last errors/warnings:
- 00107.424 E: Unable to access image: java.security.AccessControlException: access denied ("java.io.FilePermission" "<josm.pref>\images\dialogs\delete.png" "read")
- 00107.424 E: Unable to access image: java.security.AccessControlException: access denied ("java.io.FilePermission" "<josm.pref>\dialogs\delete.png" "read")
- 00107.429 E: Unable to access image: java.security.AccessControlException: access denied ("java.io.FilePermission" "<josm.pref>\images\cancel.png" "read")
- 00107.435 E: Unable to get system env: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "getenv.JOSM_RESOURCES")
- 00107.435 E: Unable to get system property: java.security.AccessControlException: access denied ("java.util.PropertyPermission" "josm.resources" "read")
- 00107.436 E: Unable to get system env: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "getenv.APPDATA")
- 00107.436 E: Unable to access image: java.security.AccessControlException: access denied ("java.io.FilePermission" "<josm.pref>\images\cancel.png" "read")
- 00107.437 E: Unable to access image: java.security.AccessControlException: access denied ("java.io.FilePermission" "<josm.pref>\cancel.png" "read")
- 00107.539 W: java.util.concurrent.ExecutionException: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "accessClassInPackage.com.sun.java.swing.plaf.windows"). Cause: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "accessClassInPackage.com.sun.java.swing.plaf.windows")
- 00107.546 E: Exception raised in EDT: java.util.concurrent.ExecutionException: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "accessClassInPackage.com.sun.java.swing.plaf.windows"). Cause: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "accessClassInPackage.com.sun.java.swing.plaf.windows")

[timothee.duhamel@…]

Log file of a JOSM run where I unchecked the checkbox, and added a building to show that it still merges building and address node

[taylor.smock]

Thank you for the log file.

In this case, I did not need it. I just wasn't saving the checkbox state (I know I was at one time).

Anyway, I've got a fix incoming. See ​https://gitlab.com/gokaart/JOSM_MapWithAI/-/merge_requests/281 .
Pretty much as soon as the pipeline finishes and it merges, I'll tag a new release. So you should have that fix in ~1 hour.