[PATCH] Fix MultiSelect issues

[marcello@…]

This patch changes <multiselect>s in presets to accept custom values. The old behaviour was to disable itself whenever an unknown value was found.

Fixes: #21385 #21404 #19013

[Don-vip]

In 18254/josm:

fix #21408 - fix #19013, fix #21385, fix #21404 - Fix MultiSelect issues (patch by marcello)

[Don-vip]

Thank you! :)

[skyper]

Yes, thank you a lot.

I am still testing so this is just my first feedback but I found some issues:

Major:

• with two objects with different values selected, adding another value results in adding <different>; + the new value as value.

Minor:

• please, hide the number in parentheses at the end of the value if only one object is selected
• icons in the value list vanish if all objects have the same values

Not new, we miss a stronger indication for different values with checks. Right now it is enabled even if the tag is only present on some selected objects. With multiple values there is a small indication but I'd rather like to see a question mark ? or something else but not a check.

Some of the new Jenkins warnings might be worth fixing.

[skyper]

Regarding row="", I still get scrollbars if the last value's icon is too tall. Probably icon height is not taken into account, yet.

[skyper]

Replying to skyper:

Regarding row="", I still get scrollbars if the last value's icon is too tall. Probably icon height is not taken into account, yet.

An example is the tower:type value list in the "General preset Mast" in Presets/MastAndTower.

[marcello@…]

I don't like it myself how <multiselect> works in conjunction with multiple selected primitives. It is very difficult to understand. It would probably be better to disable it if multiple primitives are selected.

Eg. if you select <different> + another value it does not add that value to what is already present on the selected primitives. It cannot do that because we can only write the same value to all selected primitives. (A limitation of the command interface.) What it can do is to overwrite all selected primitives with that value. I'm not sure it should, though.

As for the icon: it works for me. Maybe a skin issue? Which look&feel do you use?

[skyper]

Replying to marcello@…:

I don't like it myself how <multiselect> works in conjunction with multiple selected primitives. It is very difficult to understand. It would probably be better to disable it if multiple primitives are selected.

At least with different values, this might be better.

Eg. if you select <different> + another value it does not add that value to what is already present on the selected primitives. It cannot do that because we can only write the same value to all selected primitives. (A limitation of the command interface.) What it can do is to overwrite all selected primitives with that value. I'm not sure it should, though.

That works, too. Gives the user more options but also more responsibility.

As for the icon: it works for me. Maybe a skin issue? Which look&feel do you use?

I have tested with "Metal" and now "Dracula" from flatlaf plugin. With both the icons vanish.

1. Install Presets/MastAndTower
2. Add a new node, select it and open "Big communication tower" preset (only first letter a capital one) from the external preset.

The icon for tower:type=communication is missing.

1. Additionally, select tower:type=observation
2. Close Preset (Ctrl+Return)
3. Open Preset again

Now both icons are missing.

[marcello@…]

Fixes vanishing icons, and scrollpane size if icons have different sizes. Also disables multiselect if the selected primitives have different values.

[Don-vip]

In 18257/josm:

fix #21408 - Fixes vanishing icons, and scrollpane size if icons have different sizes. Also disables multiselect if the selected primitives have different values (patch by marcello)

[Don-vip]

@marcello: this {2}List is weird, is it a copy-paste error?

Logging.error(tr("Broken tagging preset \"{0}-{1}\" - number of items in ''{2}List'' must be the same as in ''values''",
                key, text, name));

[marcello@…]

Actually it is correct, but I'll provide a better error message.

[Don-vip]

I don't see how to translate this in French.

[Don-vip]

there's a problem with the patch it doesn't apply nicely?

[marcello@…]

replaced. try now

[Don-vip]

In 18258/josm:

see #21408 - fixups (patch by marcello)

[Don-vip]

much better, thanks.

[gaben]

The taggingpreset.fill-default-for-tagged-primitives setting stopped working in r18254.

[marcello@…]

patch: fix fill-default property, add tests

[Don-vip]

In 18260/josm:

fix #21408 - fix fill-default property, add tests (patch by marcello)

[gaben]

Thank you!

[Don-vip]

Milestone renamed