[Patch] Hashtag which starts from digit is not added to changset's details

[NieWnen]

If hashtag in changeset's message starts from a digit then is not detected by JOSM in changeset's hashtags.

It wasn't a problem until latest update where JOSM automatically removes hashtags, so if I try to create it manually by adding hashtags key and values to the current changeset's details in the settings tab, then JOSM will remove it immediately.

What steps will reproduce the problem?

1. Make any change
2. Open upload dialog and type message with hashtag which starts from digit. Example hashtag: #3D. Example changeset message: "Add roof colour to building #3D".
3. Check settings tab – there won't hashtags from message

4. Try to add it manually in settings tab

What is the expected result?

Details with: "hashtags": "#3D"

What happens instead?

For 3: Nothing.
For 4: It will be removed immediately

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Revision:18193
Build-Date:2021-09-03 01:31:19
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18193 pl) Linux Ubuntu 18.04.5 LTS
Memory Usage: 1411 MB / 4096 MB (53 MB allocated, but free)
Java version: 11.0.11+9-Ubuntu-0ubuntu2.18.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00) :0.1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: pl_PL.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: pl_PL
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: ubuntu:GNOME
Java package: openjdk-11-jre:amd64-11.0.11+9-0ubuntu2~18.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-20ubuntu0.1
libcommons-logging-java: libcommons-logging-java:-
fonts-noto: fonts-noto:-
Program arguments: []
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (35814)
+ Mapillary (2.0.0-alpha.34-dirty)
+ PicLayer (1.0.1)
+ apache-commons (35524)
+ apache-http (35589)
+ ejml (35458)
+ geotools (35458)
+ gridify (1606242219)
+ jaxb (35543)
+ jna (35662)
+ jogl (1.2.3)
+ jts (35458)
+ kendzi3d (1.0.205)
+ kendzi3d-resources (0.0.2)
+ log4j (35458)
+ measurement (35640)
+ pdfimport (35640)
+ reverter (35732)
+ tageditor (35640)
+ todo (30306)
+ turnlanes-tagging (288)
+ utilsplugin2 (35792)

Tagging presets:
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- 00116.208 E: Nie udało się zlokalizować obrazu „construction--barrier--concrete-block'
- 00116.208 E: Nie udało się zlokalizować obrazu „construction--barrier--concrete-block'
- 00116.256 E: Nie udało się zlokalizować obrazu „construction--barrier--concrete-block'
- 00116.256 E: Nie udało się zlokalizować obrazu „construction--barrier--concrete-block'
- 00116.258 E: Nie udało się zlokalizować obrazu „object-sign-other'
- 00519.640 E: Nie udało się zlokalizować obrazu „construction--barrier--concrete-block'
- 00519.640 E: Nie udało się zlokalizować obrazu „construction--barrier--concrete-block'
- 00519.641 E: Nie udało się zlokalizować obrazu „object-sign-other'
- 08277.463 W: java.net.SocketException: Unexpected end of file from server. Przyczyna: java.net.SocketException: Unexpected end of file from server
- 13532.804 W: Nie wybrano domyślnej warstwy; wybieranie pierwszej warstwy.

[marcello@…]

Added patch

[marcello@…]

This is a semantic change. Are hashtags starting with digits legal? That would make #42 a valid hashtag. I have no opinion either way. Just asking.

[niewnen]

Replying to marcello@…:

This is a semantic change. Are hashtags starting with digits legal? That would make #42 a valid hashtag. I have no opinion either way. Just asking.

I am not sure about digit as the first character is legal or not, but I downloaded changesets from yesterday and (random day before breaking update) 2021-08-30 to analyze hashtags.

If I did it properly:

For yesterday there were 16.8k changesets with hashtags and 85 start from digit.
For 2021-08-30 there were 12.7k changesets with hashtags and 131 start from digit

So mappers do it anyway.

[marcello@…]

Then we should legalize it. I just wondered because there is a unit test that says otherwise.

[marcello@…]

Second patch fixes unit test too.

[niewnen]

Replying to marcello@…:

Second patch fixes unit test too.

Thank you!

[Don-vip]

In 18205/josm:

fix #21309 - allow changeset hashtags to start with digits (patch by marcello)

[Don-vip]

Milestone renamed