[Patch] search history is truncated for very long items

[GOwin]

What steps will reproduce the problem?

1. Activate search
2. Start typing to retrieve history of previous search
3. The display will show a truncated version of a previous (long) search string , with an ellipsis in the end, which causes an error.

Short search strings work as expected but long ones like this don't.

What is the expected result?

Should show the full text of the previous search, not a truncated version that causes an error. In this case, I was looking for a previous search: "highway -name type:way -(service|track|road|path|footway|steps|construction|trunk_link|primary_link|secondary_link|tertiary_link)"

What happens instead?

Instead I get: "highway -name type:way -(service|track|road|path|footway|steps|construction|trunk_link|primary_li..." , which is the truncated version.

Please provide any additional information below. Attach a screenshot if possible.

Screenshot:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Revision:18193
Build-Date:2021-09-03 01:31:19
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18193 en) Linux Pop!_OS 20.04 LTS
Memory Usage: 1007 MB / 6144 MB (217 MB allocated, but free)
Java version: 11.0.11+9-Ubuntu-0ubuntu2.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatIntelliJLaf
Screen: :0.0 1360×768 (scaling 1.00×1.00) :0.1 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: XFCE
Java package: openjdk-11-jre:amd64-11.0.11+9-0ubuntu2~20.04
fonts-noto: fonts-noto:all-20200323-1build1~ubuntu20.04.1
Dataset consistency test: No problems found

Plugins:
+ Lanes (${version.entry.commit.revision})
+ Mapillary (2.0.0-alpha.34-dirty)
+ OpeningHoursEditor (35640)
+ RoadSigns (35640)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35756)
+ centernode (v1.0.4)
+ contourmerge (v0.1.8)
+ easypresets (1616854084)
+ ejml (35458)
+ flatlaf (35799)
+ geotools (35458)
+ imagery_offset_db (35640)
+ intersection (0.0.7)
+ jaxb (35543)
+ jna (35662)
+ josm-batch-downloader (1.0.4)
+ jts (35458)
+ log4j (35458)
+ mapwithai (1.8.2)
+ measurement (35640)
+ merge-overlap (35640)
+ namemanager (35567)
+ opendata (35803)
+ openqa (0.2.2)
+ reverter (35732)
+ tageditor (35640)
+ terracer (35640)
+ todo (30306)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35792)
+ waydownloader (35640)

Tagging presets:
+ ${HOME}/Documents/Projects/#Kaart/JOSM/Reviewed_Features/reviewed_preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/PhilippinesAddresses&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- ${HOME}/Documents/Projects/#Kaart/JOSM/Kaart Styles 3.1.1.mapcss
- ${HOME}/Documents/Projects/#Kaart/JOSM/geometry_adjusted_paint.mapcss.css
- ${HOME}/Documents/Projects/#Kaart/JOSM/Reviewed_Features/reviewed_features.mapcss
- https://raw.githubusercontent.com/govvin/JOSM-styles/master/age.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- ${HOME}/Documents/Projects/#Kaart/resources/data_age.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Overlapping%20Ways.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart_QC.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart-Styles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- resource://mapcss/Mapillary.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- ${HOME}/Documents/Projects/OpenStreetMap/MapCSS/MapCSS-JOSM-Bicycle-master/cycleway.mapcss
- https://pasharm.github.io/New_basic_style_for_JOSM/New_basic_style.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_PAC.zip

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OsmoseValidations&zip=1
+ https://github.com/KaartGroup/KaartValidator/raw/master/kaart.validator.mapcss
- https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
- https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1

Last errors/warnings:
- 00299.735 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00299.772 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00299.788 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00299.849 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00330.152 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00330.153 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00330.171 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00330.204 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00330.249 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00330.297 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out

[marcello@…]

Patch: do not shorten search string in combobox.

[Don-vip]

In 18197/josm:

fix #21291 - do not shorten search string in combobox (patch by marcello)

[GOwin]

The same issue described above occurs when trying to edit existing filters that are also long:

Should I file a separate ticket?

[Don-vip]

it's ok to reopen here

[marcello@…]

works here. maybe that filter was stored truncated. try to fix it and save it again.

[skyper]

Works for me, too:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-08 23:40:00 +0200 (Wed, 08 Sep 2021)
Revision:18204
Build-Date:2021-09-09 01:31:06
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18204 en) Linux Debian GNU/Linux 11 (bullseye)
Java version: 17-ea+19-Debian-1, Debian, OpenJDK 64-Bit Server VM

Replying to GOwin:

Java version: 11.0.11+9-Ubuntu-0ubuntu2.20.04, Ubuntu, OpenJDK 64-Bit Server VM

Strange, Debian rolled out openjdk 11.0.12 completely, but ubuntu still uses 11.0.11.

[Don-vip]

Milestone renamed