[Patch] Warn about `levels=*` and ignore it in "Presets do not contain property key"

[skyper]

What steps will reproduce the problem?

1. Have a closed way with levels=* among the tags
2. Run validator

What is the expected result?

One warning about deprecated levels=*

What happens instead?

Two warnings, one about deprecation and additionally Presets do not contain property key - Key 'levels' not in presets

Please provide any additional information below. Attach a screenshot if possible.

levels=* needs to be ignored on the preset test.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-08-26 16:42:55 +0200 (Thu, 26 Aug 2021)
Revision:18182
Build-Date:2021-08-27 01:31:01
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

patch file

[skyper]

Please, find attached patch​ which adds levels to the list of deprecated tags.

[skyper]

Ah, sorry, the deprecated warning only works with building=*, so a more general warning about level=* is needed.

*[levels][!building][!building:part] {
  throwWarning: tr("{0} is unusual, maybe {1} or {2} is meant", "{0.key}", "level", "building:levels");

[skyper]

The existing rule for building should be changed to warn on all building:part and not only on building:part=yes.

[skyper]

version 2, checks on all building parts and adds general rule

[skyper]

I've attached version 2​ which checks on all building:part and adds a general warning about levels=*.

[Don-vip]

In 18188/josm:

fix #21268 - Warn about levels=* and ignore it in "Presets do not contain property key" (patch by skyper)

[skyper]

Thanks for applying.

I did not add a milestone on purpose or should have better set 21.9 as this introduced a new string to translate.