[PATCH] RemoteControl: Empty changeset_source prevents "Automatically obtain source from current layers" from working

[TrickyFoxy]

What steps will reproduce the problem?

1. Include satellite imagery (Bing & Maxar).
2. Make the changes.
3. Open the Load changes menu.

The checkbox "Automaticly obtain source from current layers" is active, but the input field is empty.

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Revision:18182
Is-Local-Build:true
Build-Date:2021-08-26 15:03:32

Identification: JOSM/1.5 (18182 SVN ru) Mac OS X 11.5
OS Build number: macOS 11.5.1 (20G80)
Memory Usage: 1414 MB / 2048 MB (301 MB allocated, but free)
Java version: 17-ea+35, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: Display 69732352 1680×1050 (scaling 2.00×2.00)
Maximum Screen Size: 1680×1050
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: ru_RU
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=18182, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM]
Dataset consistency test: No problems found

Plugins:
+ BuildingGeneralization (36)
+ ColorPlugin (1537115529)
+ Create_grid_of_ways (35640)
+ CustomizePublicTransportStop (35760)
+ DirectDownload (35640)
+ EasyPresets (1623509627)
+ FastDraw (35640)
+ FixAddresses (35640)
+ HouseNumberTaggingTool (35640)
+ ImproveWay (32)
+ MakeParallel (v1.1.0)
+ Mapillary (2.0.0-alpha.32-dirty)
+ OpeningHoursEditor (35640)
+ PicLayer (1.0.1)
+ PolygonCutOut (v0.7)
+ RelationDissolve (0.2.0)
+ ShapeTools (1240)
+ SimplifyArea (35640)
+ alignways (35753)
+ apache-commons (35524)
+ apache-http (35589)
+ auto_tools (81)
+ buildings_tools (35756)
+ changeset-viewer (25)
+ conflation (0.6.6)
+ continuosDownload (99)
+ contourmerge (v0.1.8)
+ editgpx (35562)
+ ejml (35458)
+ ext_tools (35640)
+ flatlaf (35799)
+ graphview (35640)
+ jaxb (35543)
+ jna (35662)
+ jogl (1.2.3)
+ jts (35458)
+ junctionchecking (35640)
+ log4j (35458)
+ markseen (14)
+ measurement (35640)
+ merge-overlap (35640)
+ openqa (0.2.2)
+ photoadjust (35770)
+ rasterfilters (35774)
+ reltoolbox (35640)
+ russia-address-helper (0.5.1)
+ splinex (35718)
+ tageditor (35640)
+ terracer (35640)
+ turnlanes (35812)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35792)
+ waydownloader (35640)
+ wikidata (1.2.3)
+ wikipedia (1.1.4)

Tagging presets:
+ https://raw.githubusercontent.com/ruosm-presets/literan-moscow/master/russian_shops.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/StreetCabinet&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-highways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-stops&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/RU.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ <josm.userdata>/EasyPresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/WifiHotspots&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/MappingAccessibility&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/FixmeAndNote&zip=1
+ ${HOME}/JOSM/presets/style-power-voltage-color.mapcss
- ${HOME}/JOSM/presets/style-power-tower-solid/power-tower-solid.mapcss
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Power&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PowerMapping&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
+ https://raw.githubusercontent.com/yopaseopor/indoormap/master/indoormap-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://raw.githubusercontent.com/zetx16/Josm-HnumbValidator/master/ru-housenumber.validator.mapcss

Last errors/warnings:
- 02005.284 E: 	at java.desktop/java.awt.Container.createHierarchyEvents(Unknown Source)
- 02005.284 E: 	at java.desktop/java.awt.Container.createHierarchyEvents(Unknown Source)
- 02005.285 E: 	at java.desktop/java.awt.Container.addImpl(Unknown Source)
- 02005.286 E: 	at java.desktop/java.awt.Container.add(Unknown Source)
- 02005.287 E: 	at java.desktop/javax.swing.JOptionPane.initDialog(Unknown Source)
- 02005.288 E: 	at java.desktop/javax.swing.JOptionPane.createDialog(Unknown Source)
- 02005.288 E: 	at java.desktop/javax.swing.JOptionPane.showOptionDialog(Unknown Source)
- 02005.288 E: 	at org.openstreetmap.josm.io.remotecontrol.handler.RequestHandler.checkPermission(RequestHandler.java:213)
- 02005.289 E: 	at org.openstreetmap.josm.io.remotecontrol.handler.RequestHandler.handle(RequestHandler.java:86)
- 02005.289 E: 	at org.openstreetmap.josm.io.remotecontrol.RequestProcessor.run(RequestProcessor.java:264)

[marcello@…]

Probably my fault because I recently changed the upload dialog. But this works for me on Linux with both GTK and Metal L&F. Don't have a Mac to test though.

[taylor.smock]

It works for me on Mac.

Mapillary will also report back a source, but it is working for me as well.

Is-Local-Build:true

Stupid question: Have you tried running ant clean dist? A non-modified file may not be working properly if you just ran ant or ant dist (these do not recompile non-modified files, which can lead to surprising behavior).

[TrickyFoxy]

But I downloaded JOSM from ​https://github.com/JOSM/josm/releases 🤔

[taylor.smock]

Replying to TrickyFoxy:

But I downloaded JOSM from ​https://github.com/JOSM/josm/releases 🤔

OK. I'll have to check and see if GitHub caches stuff between runs.

Can you try running a version from https://josm.openstreetmap.de, just for a sanity check? (If you can, the .jar file).

EDIT: It doesn't look like GitHub is caching build artifacts between runs, but only tested versions get built without the Is-Local-Build:true line in the CI. I believe this is different as compared to the versions shown on the JOSM homepage.

Which version are you running (from the GitHub asset list)? I'd guess one of the JOSM-macOS-java17-ea-18182 versions, but I don't know which one (probably the .zip).

[TrickyFoxy]

The bug disappeared some time ago and came back once. It looks like it will be difficult to reproduce it now. I'll let you know if it comes up again.

Which version are you running (from the GitHub asset list)? I'd guess one of the JOSM-macOS-java17-ea-18182 versions, but I don't know which one (probably the .zip).

Yes, JOSM-macOS-java17-ea-18182.zip. I have now upgraded to 18184.

EDIT: The Is-Local-Build:true flag is still present in version 18184

[TrickyFoxy]

I found a way to reproduce this bug.

1. Start JOSM
2. Select the task in ​https://maproulette.org/browse/challenges/20710
3. Select Edit in JOSM
4. In JOSM, add layers with satellite imagery(Bing & Maxar)
5. Edit something.
6. Open the Load changes menu.

[taylor.smock]

​http://127.0.0.1:8111/load_and_zoom?left=39.041105210781105&right=39.04432117938996&top=52.39790368528829&bottom=52.39655182091353&new_layer=false&layer_name=MR%20Task%20103810006&changeset_comment=&changeset_source=&select=node766022292

Note the changeset_comment= and changeset_source=. Those probably override those that are autogenerated by JOSM.

[ottwiz]

@TrickyFoxy I experience the same issue with opening a project from OSMUS tasking manager (that is based on HOTOSM TM)

[taylor.smock]

RemoteControl: Don't add empty changeset tags to the dataset

[taylor.smock]

attachment:21256.patch​:

• RemoteControl no longer adds "" to the dataset changesets (for changeset_ keys). Instead, it passes null to the map
• DataSet#addChangesetTag now accepts a null value, which removes the key from the map.

[Don-vip]

In 18200/josm:

fix #21256 - RemoteControl: Don't add empty changeset tags to the dataset (patch by taylor.smock):

• RemoteControl no longer adds "" to the dataset changesets (for changeset_ keys). Instead, it passes null to the map
• DataSet#addChangesetTag now accepts a null value, which removes the key from the map

[Don-vip]

Milestone renamed