Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21245 closed defect (invalid)

turnrestrictions plugin shortcut is not editable in Help/Preferences/Shortcuts

Reported by: leni Owned by: leni
Priority: normal Milestone:
Component: Plugin turnrestrictions Version:
Keywords: template_report shortcut Cc:

Description

What steps will reproduce the problem?

  1. The turnrestrictions and Reverter plugins are installed and usable
  2. Both use the same shortcut Ctrl+Shift+T
  3. I go to Help/Preferences/Shortcuts to change the turnrestrictions shortcut

What is the expected result?

I thought I would find turnrestrictions in the list of shortcuts

What happens instead?

I can only find Data: Revert changeset
it's the same way if I installed the todo plugin instead of reverter

Please provide any additional information below. Attach a screenshot if possible.

Editing the wiki is the subject of #21243

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-08-02 19:44:04 +0200 (Mon, 02 Aug 2021)
Build-Date:2021-08-02 18:26:20
Revision:18118
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18118 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 423 MB / 989 MB (219 MB allocated, but free)
Java version: 1.8.0_271-b09, Oracle Corporation, Java HotSpot(TM) Client VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1623509627)
+ Mapillary (2.0.0-alpha.30-dirty)
+ PicLayer (1.0.1)
+ apache-commons (35524)
+ apache-http (35589)
+ contourmerge (v0.1.8)
+ ejml (35458)
+ flatlaf (35799)
+ geotools (35458)
+ imagery_offset_db (35640)
+ indoorhelper (1.2.0)
+ javafx-windows (35655)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ photo_geotagging (35783)
+ photoadjust (35770)
+ reverter (35732)
+ scripting (30798)
+ shrinkwrap (v1.0.4)
+ tageditor (35640)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35792)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://github.com/Jungle-Bus/josm-presets/raw/gh-pages/jungle-stops/preset.zip
+ <josm.pref>/EasyPresets.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- <josm.pref>\styles\sit.mapcss
+ <josm.pref>\styles\sit.mapcss

Validator rules:
+ https://raw.githubusercontent.com/nlehuby/transport_mapcss/master/transport.validator.mapcss

Last errors/warnings:
- 00002.271 W: Failed to delete outdated plugin '<josm.pref>\plugins\flatlaf.jar'.
- 00002.272 W: Failed to install already downloaded plugin 'flatlaf'. Skipping installation. JOSM is still going to load the old plugin version.
- 00005.630 E: java.nio.file.NoSuchFileException: <josm.pref>\EasyPresets.xml
- 00005.630 E: <josm.pref>/EasyPresets.xml
- 00007.731 W: Warning: Failed to scan file 'fr.toulouse.jar' for module information. Skipping.

Attachments (3)

21245.jpg (182.9 KB ) - added by Don-vip 3 years ago.
plugins.png (8.1 KB ) - added by mdk 3 years ago.
shortcuts.png (7.3 KB ) - added by mdk 3 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 by skyper, 3 years ago

Component: CorePlugin turnrestrictions
Keywords: shortcut added

comment:2 by Don-vip, 3 years ago

Owner: changed from team to leni
Status: newneedinfo

I can't find any action in turnrestrictions plugin that registers Ctrl-Shift-T.

comment:3 by mdk, 3 years ago

That is exactly the problem. The old version (see screenshot in #21243) has his own section in his Preferences to define a shortcut. In a newer version of this plugin, this code was removed. But registering the shortcut is now missing.

by Don-vip, 3 years ago

Attachment: 21245.jpg added

comment:4 by Don-vip, 3 years ago

Resolution: invalid
Status: needinfoclosed

Yes it has been removed in r27876/osm 11 years ago and changed to Alt-Shift 2, which is configurable.


comment:5 by Don-vip, 3 years ago

In 35810/osm:

see #21245 - update javadoc

by mdk, 3 years ago

Attachment: plugins.png added

by mdk, 3 years ago

Attachment: shortcuts.png added

comment:6 by mdk, 3 years ago

Interesting. I got the Plugin:

but I didn't found the Shortcut:

Identification: JOSM/1.5 (18118 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19043)
Memory Usage: 446 MB / 4068 MB (231 MB allocated, but free)
Java version: 11.0.11+9, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1200 (scaling 1.00×1.00) \Display1 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890

Plugins:
+ ColumbusCSV (35781)
+ ImproveOsm (211)
+ OpeningHoursEditor (35640)
+ RoadSigns (35640)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35756)
+ contourmerge (v0.1.8)
+ imagery-xml-bounds (35723)
+ imagery_offset_db (35640)
+ jna (35662)
+ pt_assistant (1ff2e15)
+ reverter (35732)
+ terracer (35640)
+ turnrestrictions (35640)
+ utilsplugin2 (35792)
+ wikipedia (1.1.4)

comment:7 by leni, 3 years ago

I don't understand, yesterday it was ok, I tested using the shortcut in all the ways described in the wiki, took a screenshot https://josm.openstreetmap.de/attachment/wiki/Fr%3AHelp/Plugin/TurnRestrictions/create-turn-restriction-popup.png which I couldn't get before;
and now, I can't find the shortcut either

EDIT at 18:15: shortcut present in the preferences with or without data layer, works normally !!!

Last edited 3 years ago by leni (previous) (diff)

comment:8 by skyper, 3 years ago

Works for me, but I noticed that the shortcut is not displayed behind the item in the windows menu.

EDIT: Sorry, got confused between panel and editor. Guess there is not option for setting panel shortcuts.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-08-26 01:50:34 +0200 (Thu, 26 Aug 2021)
Revision:18178
Build-Date:2021-08-26 01:31:02
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18178 en) Linux Debian GNU/Linux 11 (bullseye)
Memory Usage: 185 MB / 256 MB (51 MB allocated, but free)
Java version: 17-ea+19-Debian-1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel

Plugins:
+ turnrestrictions (35640)
Last edited 3 years ago by skyper (previous) (diff)

comment:9 by skyper, 3 years ago

Ah, without a data layer I can reproduce and the shortcut is missing in preferences. Looks like the action is tied to data layers.

comment:10 by stoecker, 3 years ago

JOSM shortcuts only appear in the list when the action was initialized at least once. There is no "register all shortcuts at start" feature. Sorry :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain leni.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.