More flexible tagging preset dialogs

[gaben]

In a new plugin, I'd like to override some core JOSM preset layout and input fields behaviour. Unfortunately, it's not possible so far.

Why? Because the plugin would duplicate part of the default tagging presets with some extras.

Examples:

• in the preset editor, show semicolon-separated values in new rows -> e.g. phone numbers (with extra metadata at the end of the line, I made a mockup screenshot if needed)
• single preset for suffixed keys -> single preset for editing all language tags
• more?

I'm okay with programming a preset dialog for myself without touching JOSM core, but it isn't trivial either, so I'm open to suggestions. The closest thing I found is the roadsigns plugin which has some of the code I need (source available in josm svn repo, here).

[skyper]

How about a new preset file with the defaultpresets (and all other active presets or preference list) plus your extras and disabling all the duplicated presets?

[gaben]

The core defaultpresets file is fine, no need to duplicate that as the plugin only needs to modify the preset window, the tags remain the same.

[stoecker]

The preset handling including the auto-completion feature is already a very complex feature. Override parts of it is not something you really want to do. That sounds like a road to major trouble.

[gaben]

Replying to stoecker:

The preset handling including the auto-completion feature is already a very complex feature. Override parts of it is not something you really want to do. That sounds like a road to major trouble.

In this (new, not yet released) plugin, the autocomplete is unnecessary, so the first thing would be disabling that feature entirely.

I'm glad you brought it up how complex it is, may be worth a refactor. It's already blocking development, see #18513.

[marcello@…]

You asked in #21851:

Does it make improvements to something mentioned in #21228?

Probably not. But I don't quite understand what your plugin is going to do. Maybe a few screenshots would help.

[gaben]

contact preset dialog mockup

[gaben]

Replying to marcello@…:

But I don't quite understand what your plugin is going to do. Maybe a few screenshots would help.

A mockup of how I imagined the function for the contact preset. It seems complex and probably is, I know, but it would add more dynamic to the editing with instant validator feedback.