"IllegalStateException: Dialog not created yet" from AutoScaleAction on closing

[rickmastfan67]

Just happened to notice this when closing JOSM in my CL window. Sadly, it's very quick in closing, so I don't have a text log of the issue, just an Print Screen that I was able to snag since the window disappears on it's own very quickly.

Tested this with my normal and a fresh profile and was able to duplicate it in both.

Steps to reproduce:
1) Once JOSM is started, download a small area of data (doesn't matter how big).
2) Close JOSM.

What happens:
JOSM crashes in the CL with 3 issues (see attached image), the worst being an 'java.lang.IllegalStateException' thrown from AutoScaleAction (manually typed below).

SEVERE: java.lang.IllegalStateException: Dialog not created yet. Invoke createInstance() first

Doesn't trigger if no data is downloaded.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-07-12 02:41:41 +0200 (Mon, 12 Jul 2021)
Build-Date:2021-07-12 00:42:49
Revision:18004
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18004 en) Windows 7 64-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 506 MB / 1820 MB (270 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890

Plugins:
+ OpeningHoursEditor (35640)
+ buildings_tools (35756)
+ measurement (35640)
+ reverter (35732)
+ tageditor (35640)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35691)

[rickmastfan67]

Please delete the first attachment (crashlog.png). The new one is clearer, plus I didn't notice in the first one that part of my desktop was visible due to transparency because I caught it when it was as it was closing itself and don't want that info left here.

Thank you.

[Don-vip]

r12235 was a lazy fix...

[Don-vip]

In 18005/josm:

fix #21103 - see #14605 - proper fix of IllegalStateException in AutoScaleAction

[skyper]

Replying to rickmastfan67:

Please delete the first attachment (crashlog.png). The new one is clearer, plus I didn't notice in the first one that part of my desktop was visible due to transparency because I caught it when it was as it was closing itself and don't want that info left here.

Note: You can replace attachments which you uploaded, using the checkbox below the file path and the description in the upload dialog.

[rickmastfan67]

Replying to skyper:

Replying to rickmastfan67:

Please delete the first attachment (crashlog.png). The new one is clearer, plus I didn't notice in the first one that part of my desktop was visible due to transparency because I caught it when it was as it was closing itself and don't want that info left here.

Note: You can replace attachments which you uploaded, using the checkbox below the file path and the description in the upload dialog.

Never noticed that. Good to know for the future.