[Patch] "Role 'section' is not among expected values 'device/from/to/force'" while creating average_speed enforcement

[Talkless]

I get complain about "section" field for these relations using JOSM 17919 on Debian Sid:

​https://www.openstreetmap.org/relation/12921878
​https://www.openstreetmap.org/relation/12921877

There's "section" key for "average_speed" enforcement:
JOSM 17919 on Debian Sid.

​https://wiki.openstreetmap.org/wiki/Relation:enforcement#Members

[Klumbumbus]

In 17948/josm:

fix #21069 - Add enforcement=average_speed with role section

[skyper]

Do not think that will work. We need an own preset for "average_speed".

[skyper]

"section" is required, but only for this type of enforcement.

[skyper]

patch

[skyper]

josm_21069_v2.patch​ should do the trick.

[skyper]

patch version 2 with correct order of values and additional keys

[Klumbumbus]

In 17949/josm:

see #21069 - Split up enforcement=average_speed preset, small adjustmenst to the presets (patch by skyper partly included)

[skyper]

Thanks.

[skyper]

Looking at the examples, member_expression might be useful:

…
            <roles>
                <role key="device" text="location of enforcement device" requisite="required" type="node,way,closedway" member_expression="highway=speed_camera" />
                <role key="from" text="node on way where enforcement starts" requisite="required" type="node" />
                <role key="to" text="where enforcement ends" requisite="optional" type="node" />
                <role key="section" text="ways forming the section of messurement" requisite="required" type="way" member_expression="highway" />
            </roles>

[Klumbumbus]

highway=speed_camera is a different tagging method and not needed for the enforcement relation. But we can add the member expression for the section role.

[skyper]

Replying to Klumbumbus:

highway=speed_camera is a different tagging method and not needed for the enforcement relation. But we can add the member expression for the section role.

Just wonder how the "device" should be tagged then, but well, I am fine with only the expression for "section".

[Klumbumbus]

In 17951/josm:

see #21069 - Add member_expression to enforcement=average_speed preset (patch by skyper)

[Klumbumbus]

Replying to skyper:

Just wonder how the "device" should be tagged then

Just blank, without tags.

[skyper]

Maybe, it is worth thinking about splitting all enforcement relations into own presets for each enforcement=* by creating one more level (subgroup) in the menu. Common parts, like roles, could still use chunks. New ticket?

[Don-vip]

In 17958/josm:

see #21069 - fix i18n typo

[Don-vip]

Replying to skyper:

New ticket?

Yes please. Working on the 21.06 release right now.

[skyper]

Replying to Don-vip:

In 17958/josm:

see #21069 - fix i18n typo

Thank you.

Replying to Don-vip:

Replying to skyper:

New ticket?

Yes please. Working on the 21.06 release right now.

Good to know that there will be release this week. Thanks for your work.
See #21081 for the new ticket.