IAE in MapillarySequenceUtils.getNextOrPrevious()

[Bjoeni]

Not sure what exactly happened. I think I clicked on another picture before the previous one was loaded.

Revision:17921
Is-Local-Build:true
Build-Date:2021-06-18 11:33:10

Identification: JOSM/1.5 (17921 SVN de) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (21390)
Memory Usage: 1580 MB / 4096 MB (496 MB allocated, but free)
Java version: 15.0.1+9-18, Oracle Corporation, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarkLaf
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 2560×1440 (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:53520, -javaagent:C:\Users\...\eclipse\java-2021-03\eclipse\configuration\org.eclipse.osgi\625\0\.cp\lib\javaagent-shaded.jar, -Dfile.encoding=UTF-8]
Program arguments: [--debug]

Plugins:
+ InfoMode (35543)
+ Mapillary (2.0.0-alpha.12.2)
+ MicrosoftStreetside (35248)
+ apache-commons (35524)
+ apache-http (35589)
+ flatlaf (35734)
+ javafx-windows (35655)
+ jna (35662)
+ photo_geotagging (35738)
+ photoadjust (35770)
+ utilsplugin2 (35691)

Last errors/warnings:
- 02857.259 E: java.util.concurrent.TimeoutException
- 02862.261 E: java.util.concurrent.TimeoutException
- 02867.264 E: java.util.concurrent.TimeoutException
- 02867.292 E: Region [mapillary:image:thumbnailImage_BLOCK_v2] : Problem storing keys.
- 02867.295 E: Region [mapillary:image:fullImage_BLOCK_v2] : Problem storing keys.
- 02867.695 E: java.io.IOException: stream is closed
- 02867.932 E: java.io.IOException: stream is closed
- 02867.995 E: java.io.IOException: stream is closed
- 02868.271 E: java.io.IOException: stream is closed
- 02890.604 E: Handled by bug report queue: java.lang.IllegalArgumentException: Illegal Capacity: -1



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (26) of main
java.lang.IllegalArgumentException: Illegal Capacity: -1
	at java.base/java.util.ArrayList.<init>(ArrayList.java:160)
	at org.openstreetmap.josm.plugins.mapillary.utils.MapillarySequenceUtils.getNextOrPrevious(MapillarySequenceUtils.java:64)
	at org.openstreetmap.josm.plugins.mapillary.actions.SelectNextImageAction.lambda$static$398c2a22$1(SelectNextImageAction.java:134)
	at org.openstreetmap.josm.plugins.mapillary.actions.SelectNextImageAction.updateEnabled(SelectNextImageAction.java:187)
	at org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog.updateButtonStates(MapillaryMainDialog.java:555)
	at org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog.updateImage(MapillaryMainDialog.java:449)
	at org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog.updateImage(MapillaryMainDialog.java:424)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:316)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[skyper]

Well, #20999 was not really fixed, I guess.

[taylor.smock]

Math.min -> Math.max. Oops.

[taylor.smock]

Fixed in ​https://github.com/JOSM/Mapillary/releases/tag/v2.0.0-alpha.14 and ​https://github.com/JOSM/Mapillary/releases/tag/v2.0.0-alpha.12.3.