Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21010 closed enhancement (fixed)

Ask for power poles/towers operator at least in France

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone:
Component: External rule Version:
Keywords: power, pole, operator Cc:

Description

Dear maintainers

National mapping projects about power poles and power towers go well in France since beginning of 2021.
Operator's name is an important information to have when it comes to mapping power supports.

Depending on your interpretation of https://wiki.openstreetmap.org/wiki/Tag:power%3Dpole, is it possible to raise a low level warning when a power=pole or power=tower is edited without operator=* please?
operator=* is recommended.

If it doesn't sound relevant to do so worldwide, is it possible to add it in France only please?

All the best

Attachments (0)

Change History (7)

comment:1 by skyper, 3 years ago

Questions:

  • Only warn about pole or more values like station, substation and [minor_]line without operator=*?
  • Does an informal warning solve it, or is a "normal" warning needed.
    • Users can still add the test to their validator ignore file.
  • Does it make sense to have an own core or external rules file for power tags or is it fine to have test within the common rules' files?
    • An own file make it possible to en-/disable the testS through preferences without individual ignore file.

comment:2 by skyper, 3 years ago

Owner: changed from team to francois.lacombe
Status: newneedinfo

comment:3 by francois.lacombe, 3 years ago

Answers:

  • Only for power=tower and power=pole currently
  • A normal warning is needed: it's intended to encourage French mappers to look for the operator. If we expect them to add a test in their own validator file, 90% of contributors will miss it
  • To me, it should be added where power tests are currently, no need to change behavior

comment:4 by skyper, 3 years ago

Owner: changed from francois.lacombe to team
Status: needinfonew

Well, all power tests are in java code (PowerLines.java), atm, see #16247, but this test is easily written in mapcss. In my eyes, it does not fit that well in combinations.mapcss and I would not enable it for the whole planet, right now. That is why I thought about a new file for power and similar infrastructure like telecommunication without restriction to France which would make it much easier to disable these test.

Still the easiest solution is to add it to the external french rules and below should work

node[power ~= /^(pole|tower)$/][!operator][inside("FR")] {
  throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
  group: tr("missing tag");
}

comment:5 by francois.lacombe, 3 years ago

Thank you Skyper for clarification.

According to what you describe, the best option is the French rules file.
I've added a check in revision 62.

I wasn't aware power tests have been moved to a dedicated java file. I'll keep in mind for next time.

Let's close this ticket if it's ok :)

comment:6 by Klumbumbus, 3 years ago

Component: Core validatorExternal rule
Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.