Modify

Opened 3 years ago

Closed 3 years ago

#21000 closed defect (fixed)

[Patch] Wrong link in help

Reported by: leni Owned by: team
Priority: normal Milestone: 21.06
Component: Core Version:
Keywords: template_report windows menu help topic Cc:

Description (last modified by leni)

What steps will reproduce the problem?

  1. I click on the main "windows" menu
  2. I use F1

What is the expected result?

Displaying the "Windows menu" page in the "JOSM Help Browser" (https://josm.openstreetmap.de/wiki/Help/Menu/Windows)

What happens instead?

Displaying an "Help content for help topic missing" in the "JOSM Help Browser"
if I click on the link for the external browser I arrive on https://josm.openstreetmap.de/wiki/Help/Help/Menu/Windows with double Help/

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-06-02 22:03:39 +0200 (Wed, 02 Jun 2021)
Build-Date:2021-06-02 20:11:30
Revision:17919
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17919 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 271 MB / 989 MB (109 MB allocated, but free)
Java version: 1.8.0_271-b09, Oracle Corporation, Java HotSpot(TM) Client VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1616852928)
+ HouseNumberTaggingTool (35640)
+ Mapillary (2.0.0-alpha.12.1)
+ PicLayer (1.0.1)
+ apache-commons (35524)
+ apache-http (35589)
+ contourmerge (v0.1.8)
+ ejml (35458)
+ flatlaf (35734)
+ geotools (35458)
+ imagery_offset_db (35640)
+ indoorhelper (1.2.0)
+ javafx-windows (35655)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ photo_geotagging (35738)
+ photoadjust (35770)
+ reverter (35732)
+ scripting (30798)
+ shrinkwrap (v1.0.4)
+ tageditor (35640)
+ todo (30306)
+ utilsplugin2 (35691)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- <josm.pref>\styles\sit.mapcss
+ <josm.pref>\styles\sit.mapcss

Validator rules:
+ https://raw.githubusercontent.com/nlehuby/transport_mapcss/master/transport.validator.mapcss

Last errors/warnings:
- 00042.010 E: Failed to locate image 'object--wire-group'
- 00042.146 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00042.881 E: Failed to locate image 'regulatory--texts--g1'
- 00042.882 E: Failed to locate image 'regulatory--texts--g2'
- 00043.036 E: Failed to locate image 'void--car-mount'
- 00043.038 E: Failed to locate image 'void--dynamic'
- 00043.039 E: Failed to locate image 'void--ego-vehicle'
- 00043.040 E: Failed to locate image 'void--ground'
- 00043.041 E: Failed to locate image 'void--static'
- 00043.249 E: Failed to locate image 'warning--kangaroo-crossing--g1'

Attachments (2)

helpTopicMissing.png (28.2 KB ) - added by leni 3 years ago.
josm_21000.patch (790 bytes ) - added by skyper 3 years ago.
untested patch

Download all attachments as: .zip

Change History (8)

by leni, 3 years ago

Attachment: helpTopicMissing.png added

comment:1 by leni, 3 years ago

Description: modified (diff)

comment:2 by leni, 3 years ago

Description: modified (diff)

by skyper, 3 years ago

Attachment: josm_21000.patch added

untested patch

comment:3 by skyper, 3 years ago

Component: Wiki contentCore
Keywords: windows menu help topic added
Summary: Wrong link in help[Patch] Wrong link in help

Please, find (untested) attached patch which should link to the proper wiki page.

comment:4 by skyper, 3 years ago

Milestone: 21.06

comment:5 by skyper, 3 years ago

r16103 did introduce the wrong path.

comment:6 by Klumbumbus, 3 years ago

Resolution: fixed
Status: newclosed

In 17925/josm:

fix #21000, see #18768 - Fix Windows menu help topic (patch by skyper)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.