Modify ↓

Opened 3 years ago

Closed 3 years ago

#20955 closed defect (fixed)

Overlapping areas: False positives with incomplete multipolygons

Reported by: skyper Owned by: Don-vip
Priority: normal Milestone: 21.07
Component: Core validator Version: tested
Keywords: template_report overlapping areas multipolygon incomplete Cc:

Description

What steps will reproduce the problem?

  1. Have some bigger, incomplete MPs sharing some children. See overlapping_area_incomplete_multipolygons.osm.xz​
  2. Run validator

What is the expected result?

No informal warnings about MPs where overlaps cannot be determined cause of incomplete children.

What happens instead?

Informal warning: Overlapping Areas (23)

Please provide any additional information below. Attach a screenshot if possible.

Downloading the members leads to the correct result of six valid warnings but 17 are false positive. See complete_multipolygons.osm.xz​ for the identical data with members downloaded.

It took me some time to figure this out as I was unable to find the overlaps, which was annoying and time consuming.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-05-27 19:45:08 +0200 (Thu, 27 May 2021)
Revision:17915
Build-Date:2021-05-28 01:31:01
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (2)

overlapping_area_incomplete_multipolygons.osm.xz​ (8.5 KB ) - added by skyper 3 years ago.
example with incomplete multipolygons
complete_multipolygons.osm.xz​ (25.4 KB ) - added by skyper 3 years ago.
same area with members downloaded

Download all attachments as: .zip

Change History (4)

by skyper, 3 years ago

Attachment: overlapping_area_incomplete_multipolygons.osm.xz​ added

example with incomplete multipolygons

by skyper, 3 years ago

Attachment: complete_multipolygons.osm.xz​ added

same area with members downloaded

comment:1 by Don-vip, 3 years ago

Milestone: → 21.07
Owner: changed from team to Don-vip
Status: new → assigned

comment:2 by Don-vip, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 18019/josm:

fix #20955 - restrict "Overlapping Areas" test to completely downloaded primitives

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.