Modify ↓

Opened 4 years ago

Last modified 12 months ago

#20898 needinfo enhancement

[WIP patch] Warn when nodes are 'merged' on geojson import

Reported by: ljdelight Owned by: ljdelight
Priority: major Milestone:
Component: Core geojson Version:
Keywords: import colocated nodes Cc:

Description

When importing a file with nodes having the same latlon, there's different import behvior between .osm and .geojson. Sample files are attached.
The .osm imports and keeps the nodes at the same latlon as separate nodes. The .geojson import will 'merge' the nodes and may drop data.

To resolve this, the user is asked if they'd like to keep One node (keeping with how JOSM has been working) or keep all nodes (keeping with how an .osm is imported).

Attachments (4)

osm-node-same-latlon.osm​ (1.5 KB ) - added by ljdelight 4 years ago.
osm-node-same-latlon.geojson​ (2.3 KB ) - added by ljdelight 4 years ago.
dialog-resolve-colocated-nodes.png​ (21.8 KB ) - added by ljdelight 4 years ago.
colocated-nodes.patch​ (15.2 KB ) - added by ljdelight 4 years ago.

Download all attachments as: .zip

Change History (10)

by ljdelight, 4 years ago

Attachment: osm-node-same-latlon.osm​ added

by ljdelight, 4 years ago

Attachment: osm-node-same-latlon.geojson​ added

by ljdelight, 4 years ago

Attachment: dialog-resolve-colocated-nodes.png​ added

by ljdelight, 4 years ago

Attachment: colocated-nodes.patch​ added

comment:1 by simon04, 4 years ago

  • Please use org.openstreetmap.josm.gui.ConditionalOptionPaneUtil for the remember this/that logic
  • Naming: "co-location" is a new term currently not used in JOSM. According to ​wikipedia:Colocation, no definition precisely matches our intended usage. We have the "Duplicated nodes" test ("This test checks that there are no nodes at the very same location"). Should be reuse this term?

comment:2 by ljdelight, 3 years ago

Hi @simon04, I have using 'duplicated notes' and I'm looking into getting the dialog refactored to use the ConditionalOptionPaneUtil.

comment:3 by Don-vip, 3 years ago

Owner: changed from team to ljdelight
Status: new → needinfo
Summary: [patch] Warn when nodes are 'merged' on geojson import → [WIP patch] Warn when nodes are 'merged' on geojson import

comment:4 by Leopard-NL, 12 months ago

Hello,

I'm very interested in this patch. When does it plan to be released?

Thank you,

Leo

comment:5 by anonymous, 12 months ago

Priority: normal → major

comment:6 by skyper, 12 months ago

Component: Core → Core geojson
Keywords: geojson removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as needinfo The owner will remain ljdelight.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from ljdelight to the specified user. Next status will be 'new'.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from ljdelight to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.