JTabPanel active tab text in white on macOS Big Sur (Java 16)

[Stereo]

This is a regression from #20075.

In src/org/openstreetmap/josm/gui/MainApplication.java we have:

} else if (PlatformManager.isPlatformOsx() && javaVersion < 16) {

because we thought that such a simple, silly bug would be fixed in Java 16.

According to ​https://bugs.openjdk.java.net/browse/JDK-8260091 it should be fixed in 16.0.1, but it obviously isn't in the latest tested JOSM.app.

I suggest bumping javaVersion < 16 to javaVersion < 17 for now.

[skyper]

Is a hotfix needed?

[Stereo]

A hotfix would be very nice, yes! It currently looks like the screenshot in #20075.

[Stereo]

I'm also wondering why the previous tested release didn't seem to have that problem, or if I just didn't notice it, or if the github java version has changed, or what.

[simon04]

A regression would be a new bug introduced with a commit during milestone:21.04. This is not the case here: the commit r17545 from 2021-02-28 just was not future-proof enough, and no-one tested Java 16 in time. I don't see the need for a hotfix.

[simon04]

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-04-27 20:35:33 +0200 (Tue, 27 Apr 2021)
Revision:17833
Build-Date:2021-04-27 21:58:39
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17833 en) Mac OS X 11.3
OS Build number: macOS 11.3 (20E232)
Memory Usage: 260 MB / 2048 MB (93 MB allocated, but free)
Java version: 16.0.1+9, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1 1440×900 (scaling 2.00×2.00) Display 2 3008×1692 (scaling 2.00×2.00)
Maximum Screen Size: 3008×1692
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_IE.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_AT
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djosm.dir.name=JOSM.xxx]

[simon04]

In 17835/josm:

fix #20821 - JTabPanel active tab text in white on macOS Big Sur (Java 16)

[Don-vip]

Definitively not worth a hotfix.