Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#20780 closed task (fixed)

New repository for a validation testing plugin

Reported by: taylor.smock Owned by: team
Priority: normal Milestone:
Component: Plugin Version:
Keywords: gitlab Cc: floscher

Description (last modified by taylor.smock)

I'd like to move some testing validations out of the MapWithAI plugin (and another plugin I've never released) into their own plugin, and I'd like to have it in the JOSM namespaces in GitHub and GitLab (GitLab might require @floscher).

Plugin repo name:

  • validations_testing

Current (experimental) checks that I will be putting in the plugin:

  • routing (MapWithAI, see also #18364)
  • stub ends (MapWithAI)
  • Missing information on road (unreleased plugin, looked for surface/maxspeed breaks, mostly useful for bridges)

Side note:
It might not be a bad idea for me to do the same with some of my other plugins (mapwithai, openqa, highwayNameModification, wikidata). I was originally intending on moving them to a JOSM controlled GitLab (see #16857 for JOSM GitLab status).

Attachments (0)

Change History (14)

comment:1 by skyper, 4 years ago

See also #18364.

comment:2 by simon04, 4 years ago

Cc: floscher added
Keywords: gitlab added

in reply to:  1 comment:3 by taylor.smock, 4 years ago

Replying to skyper:

See also #18364.

Partially. I've got some other validations I want to write and test for awhile, prior to adding to JOSM. Mostly stuff that isn't going to be "yep that looks right".

EDIT:

Current repo: https://gitlab.com/gokaart/josm_validations_testing (I've just added the maxspeed missing information to it for now).

Last edited 4 years ago by taylor.smock (previous) (diff)

comment:4 by floscher, 4 years ago

When the GitHub repository is setup, I could mirror it to https://gitlab.com/JOSM/plugin , sure.

comment:5 by taylor.smock, 4 years ago

Description: modified (diff)

comment:6 by floscher, 4 years ago

See https://gitlab.com/JOSM/plugin/validations_testing

I'm sure you know that, but just for clarification: That gitlab.com group is at the moment nothing officialy endorsed by JOSM, just an unofficial group by me.

in reply to:  6 comment:7 by taylor.smock, 4 years ago

Replying to floscher:

See https://gitlab.com/JOSM/plugin/validations_testing

I'm sure you know that, but just for clarification: That gitlab.com group is at the moment nothing officialy endorsed by JOSM, just an unofficial group by me.

I know that. :)

It does, however, make for a convenient location on GitLab for people to look for JOSM plugins. TBH, I probably should have looked into moving my other plugins to that group (again, just to make it easier for people to find JOSM plugin source code). I had been hoping that #16857 would be closed soon, but I don't think anyone is working on it right now (it has been > 1 year since there was any real movement on the infrastructure side).

I did recently post some patches to #16857 for GitLab CI, but I'm not expecting them to be merged until OSM/JOSM has a GitLab instance set up.

comment:8 by taylor.smock, 4 years ago

Is there anything I need to do on my end?

comment:9 by taylor.smock, 4 years ago

2 week ping.

comment:10 by simon04, 4 years ago

What was the question? Concerning the infrastructure migration, please see #16857, #16871, #16944. It's up to Dirk to decide whether/when the next steps are possible.

in reply to:  10 comment:11 by taylor.smock, 4 years ago

Replying to simon04:

What was the question? Concerning the infrastructure migration, please see #16857, #16871, #16944. It's up to Dirk to decide whether/when the next steps are possible.

Sorry. Bad communication on my end.

The question is "Can I have a repository made in the JOSM GitHub namespace specifically for testing complex validations in a wider audience?"

in reply to:  12 comment:13 by taylor.smock, 4 years ago

Resolution: fixed
Status: newclosed

Replying to simon04:

Done:

You should have received an invitation...

I got it. Thanks. :)

comment:14 by simon04, 4 years ago

In 35769/osm:

see #20780 - Add github.com/JOSM/validations_testing

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.