Mapillary filter state remembered incorrectly

[richlv]

Open JOSM, open a GPX, download data or do anything else to have the dialogues pane appear.
Enable Mapillary filter.
Close JOSM, reopen and make the dialogues pane appear.
Notice how Mapillary expert filter is open now.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-04-01 23:17:01 +0200 (Thu, 01 Apr 2021)
Build-Date:2021-04-01 21:46:03
Revision:17702
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17702 en_GB) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H524)
Memory Usage: 883 MB / 1820 MB (564 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1127230987 1920×1080 (scaling 1.00×1.00) Display 69733382 1680×1050 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
VM arguments: [-Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlp.tk=awt, -Djnlpx.jvm=<java.home>/bin/java, -Djnlpx.splashport=-1, -Djnlpx.home=<java.home>/bin, -Djnlpx.remove=false, -Djnlpx.offline=false, -Djnlpx.relaunch=true, -Djnlpx.session.data=/var/folders/nl/flqxqsmj5q963r7tcnfrdt3c0000gn/T/session149538299452958267, -Djnlpx.heapsize=-1,2147483648, -Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.origFilenameArg=/Users/richlv/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-72e8e992, -Dsun.awt.warmup=true, -Djava.security.manager]

Plugins:
+ InfoMode (35543)
+ Mapillary (1.5.37.6)
+ PicLayer (2a9aa7a)
+ apache-commons (35524)
+ apache-http (35589)
+ ejml (35458)
+ geotools (35458)
+ imagery_offset_db (35640)
+ javafx-osx (35655)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ pbf (35720)
+ photo_geotagging (35715)
+ reverter (35688)
+ utilsplugin2 (35691)

Map paint styles:
+ /Users/richlv/Desktop/ChangeFontSize.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 00043.313 E: Failed to locate image 'object--wire-group'
- 00043.460 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00045.116 E: Failed to locate image 'regulatory--texts--g1'
- 00045.119 E: Failed to locate image 'regulatory--texts--g2'
- 00045.344 E: Failed to locate image 'void--car-mount'
- 00045.348 E: Failed to locate image 'void--dynamic'
- 00045.352 E: Failed to locate image 'void--ego-vehicle'
- 00045.357 E: Failed to locate image 'void--ground'
- 00045.359 E: Failed to locate image 'void--static'
- 00045.795 E: Failed to locate image 'warning--kangaroo-crossing--g1'

[taylor.smock]

Thanks for reporting this.

I'll take a look once I've got everything I can port from the Mapillary v3 api to the Mapillary v4 api ported, but it shouldn't be too difficult to troubleshoot.

[taylor.smock]

Well, this was easy to debug.

I'm reusing the icon from MapillaryFilterDialog in MapillaryExpertFilterDialog, and the ToggleDialog code uses the icon name as the preference key, which means that they share preferences for:

• visibility
• dock status
• minimized status
• height status

[taylor.smock]

I've got a fix for this. It will be in the 2.0 release (which has to be done prior to the end of this month -- see Mapillary v4 transition).

While you can use the mapillary-dev plugin to see if it works, I haven't done a release yet for it, and the mapillary-dev plugin is mostly so that people can test out known good features (e.g. image viewing). It really shouldn't be used for a daily drive at this point.