Modify ↓

Opened 4 years ago

Closed 4 years ago

#20732 closed enhancement (fixed)

Migrate org.openstreetmap.josm.data.imagery.Shape#coords to java.awt.Polygon

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 21.04
Component: Core Version:
Keywords: template_report heap profiling intellij yourkit Cc:

Description

Reduces heap size of the 1049 Shape instances from 2_649_576 to 808_564.

Attachments (0)

Change History (4)

comment:1 by simon04, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 17727/josm:

fix #20732 - Migrate org.openstreetmap.josm.data.imagery.Shape#coords to java.awt.Polygon

comment:2 by Don-vip, 4 years ago

Resolution: fixed
Status: closed → reopened

It causes a massive amount (184) of "Bounds do not match shape" errors in ImageryCompare. Example:

* Bounds do not match shape (is 46.37853,9.54063,49.01266,17.17397, calculated <bounds min-lat='46.37853' min-lon='9.54063' max-lat='49.0126599' max-lon='17.17397'>): [AT] basemap.at Terrain [basemap.at-terrain]

Seems to be a rounding issue. Not sure if the script must be adapted or something fixed in JOSM code.

Last edited 4 years ago by Don-vip (previous) (diff)

comment:3 by simon04, 4 years ago

In 17737/josm:

see #20732 - SyncEditorLayerIndex: compare coordinates with epsilon

comment:4 by Don-vip, 4 years ago

Resolution: → fixed
Status: reopened → closed

Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.