Opened 3 years ago
Closed 3 years ago
#20711 closed enhancement (fixed)
[Patch] Add parking_space=* to internal presets
Reported by: | mdk | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 21.08 |
Component: | Internal preset | Version: | |
Keywords: | template_report parking_space | Cc: |
Description (last modified by )
What steps will reproduce the problem?
- Create an area with amenity=parking_space and parking_space=disabled
- Validate
What is the expected result?
No validator messages.
What happens instead?
Presets do not contain property key - Key 'parking_space' not in presets. (1)
Please provide any additional information below. Attach a screenshot if possible.
amenity=parking_space
is an approved feature. parking_space=*
is mentioned in the wiki as optional key, is well documented and used over 70k times.
But the problem is, that parking_space=*
is not approved, but only "in use".
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-04-01 23:17:01 +0200 (Thu, 01 Apr 2021) Revision:17702 Build-Date:2021-04-01 21:46:03 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (17702 en) Linux Ubuntu 20.10 Memory Usage: 1980 MB / 1980 MB (626 MB allocated, but free) Java version: 15+36-Ubuntu-1, Private Build, OpenJDK 64-Bit Server VM Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel Screen: :0.0 3840×2160 (scaling 2.00×2.00) Maximum Screen Size: 3840×2160 Best cursor sizes: 16×16→16×16, 32×32→32×32 Environment variable LANG: de_CH.UTF-8 System property file.encoding: UTF-8 System property sun.jnu.encoding: UTF-8 Desktop environment: ubuntu:GNOME Java ATK Wrapper package: libatk-wrapper-java:all-0.38.0-1 libcommons-compress-java: libcommons-compress-java:all-1.20-1 libcommons-logging-java: libcommons-logging-java:all-1.2-2 fonts-noto: fonts-noto:all-20200323-1build1 VM arguments: [--add-modules=java.scripting,java.sql, -Djosm.restart=true, -Djosm.dir.name=JOSM-latest, -Djava.net.useSystemProxies=true] Dataset consistency test: No problems found Plugins: + FastDraw (35640) + HouseNumberTaggingTool (35640) + OpeningHoursEditor (35640) + RoadSigns (35640) + SimplifyArea (35640) + buildings_tools (35669) + contourmerge (v0.1.6) + imagery-xml-bounds (35723) + imagery_offset_db (35640) + pbf (35720) + poly (35640) + public_transport (35640) + reltoolbox (35640) + reverter (35688) + terracer (35640) + turnrestrictions (35640) + utilsplugin2 (35691) + wikipedia (1.1.4) Tagging presets: + https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1 Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&style&zip=1 Last errors/warnings: - 03955.037 E: Region [api_BLOCK_v2] : Failure updating element, key: https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&formatversion=2&ids=%1FQ10299520%1FQ1103%1FQ1115063%1FQ11983535%1FQ12869285%1FQ12975794%1FQ1341545%1FQ13426605%1FQ1473366%1FQ16692773%1FQ18208944%1FQ193796%1FQ1943651%1FQ19803506%1FQ199%1FQ206166%1FQ23108%1FQ25096132%1FQ27165969%1FQ27273%1FQ28469711%1FQ28530017%1FQ28595%1FQ2901600%1FQ29710245%1FQ29711518%1FQ29715277%1FQ29715665%1FQ29716783%1FQ29717328%1FQ29809643%1FQ29996%1FQ3147025%1FQ3275031%1FQ3330225%1FQ40462%1FQ422564%1FQ484940%1FQ49404%1FQ50278473%1FQ50379086%1FQ51929218%1FQ55614204%1FQ58506623%1FQ607728%1FQ65782094%1FQ69515242%1FQ729138%1FQ82625%1FQ9893&props=aliases%7Cdescriptions%7Clabels&utf8=1 old: null - 03955.775 E: Region [api_BLOCK_v2] : Failure updating element, key: https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&formatversion=2&ids=%1FQ29932996%1FQ365900%1FQ68269&props=aliases%7Cdescriptions%7Clabels&utf8=1 old: null - 04206.493 E: Region [api_BLOCK_v2] : Failure updating element, key: https://www.wikidata.org/w/api.php?action=sitematrix&format=json&formatversion=2&utf8=1 old: null - 04356.569 E: Region [api_BLOCK_v2] : Failure updating element, key: https://www.wikidata.org/w/api.php?action=sitematrix&format=json&formatversion=2&utf8=1 old: null - 10048.407 E: Region [api_BLOCK_v2] : Failure updating element, key: https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&formatversion=2&ids=Q692113&props=aliases%7Cdescriptions%7Clabels&utf8=1 old: null - 10302.597 E: Region [api_BLOCK_v2] : Failure updating element, key: https://www.wikidata.org/w/api.php?action=sitematrix&format=json&formatversion=2&utf8=1 old: null - 18711.824 E: Region [api_BLOCK_v2] : Failure updating element, key: https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&formatversion=2&ids=Q14514&props=aliases%7Cdescriptions%7Clabels&utf8=1 old: null - 18872.681 E: Region [api_BLOCK_v2] : Failure updating element, key: https://www.wikidata.org/w/api.php?action=sitematrix&format=json&formatversion=2&utf8=1 old: null - 19936.545 W: Not downloading all tiles because there is more than 40 tiles on an axis! - 19936.545 W: Not downloading all tiles because there is more than 40 tiles on an axis!
Attachments (1)
Change History (9)
comment:1 by , 3 years ago
Description: | modified (diff) |
---|
comment:2 by , 3 years ago
Component: | Core → Internal preset |
---|---|
Keywords: | parking_space added |
Type: | defect → enhancement |
comment:3 by , 3 years ago
Once again, finding a nice looking vector-graphic icon is the major work.
comment:4 by , 3 years ago
The disabled
key is also not approved, but only used less then 8k times. Why is this key better than the 70k times used parking_space
key?
https://wiki.openstreetmap.org/wiki/How_to_map_for_the_needs_of_people_with_disabilities suggest both mappings. Could we at least add parking_space
to the ignore list?
comment:5 by , 3 years ago
Ups, why did I add it to defaultpresets and nobody complained about it. I hate these nontransparent value tables where everyone just adds items but does not refer to its development.
So, no objection to add parking_space=*
with some values. Its only a subtag and not that controversial, I'd say.
comment:6 by , 3 years ago
comment:7 by , 3 years ago
Milestone: | → 21.08 |
---|---|
Summary: | Add parking_space=* to internal presets → [Patch] Add parking_space=* to internal presets |
There is the external preset NewParkingFeatures but even that is missing the subtag
parking_space
.Why not use access?
access=no
+disabled=designated
(brr, why do we not usehandicapped=*
?)