Reverse way direction: tags depending on way direction are not adjusted anymore

[skyper]

What steps will reproduce the problem?

1. Have a way with tags depending on the direction of the way:

      "highway"="tertiary"
      "lanes"="2"
      "lanes:backward"="1"
      "lanes:forward"="1"
      "sidewalk:left"="separate"
      "sidewalk:right"="no"
      "bus_bay"="left"
      "bus:lanes:forward"="yes|designated"
      "access:lanes:forward"="yes|no"
      "change:lanes:forward"="not_right|"
   

2. Reverse direction of the way
3. Get a dialog about adjusting keys or values
4. Accept changes

What is the expected result?

Proposed changes are made

What happens instead?

No changes are made

Please provide any additional information below. Attach a screenshot if possible.

Have to find out when this stopped working but it used to work smoothly and JOSM proposes the correct changes but just does not execute them.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-03-31 20:46:00 +0200 (Wed, 31 Mar 2021)
Revision:17699
Build-Date:2021-04-01 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

[GerdP]

Maybe the changes in r17597 caused this?

[GerdP]

Yes, just tried it. When I reverse the changes from 17597 the problem disappears.

[simon04]

Thanks for reporting and for debugging. The fix should be rather easy...

[simon04]

In 17702/josm:

fix #20699, see #20048 - Fix dialog result handling of "Automatic tag correction"

[simon04]

@Vincent, can we release a hotfix, please? Maybe this breaks the record for the shortest timespan between release and hotfix. :-/

[Don-vip]

Haha sure.

[skyper]

Well, it was pure luck that I was lazy in :lanes tagging and reverted the way direction first to add tags together with some other ways and change the direction afterward again, plus, I had an style active with feedback.

Hope I did not damage too much data the last week.

[simon04]

Replying to Don-vip:

Haha sure.

Thank you, Vincent!

[Don-vip]

Replying to simon04:

Replying to Don-vip:

Haha sure.

Thank you, Vincent!

You're welcome. Please hold on any major change until Monday. With the WebStart => OpenWebStart migration I might need to release another hotfix in case we find an issue preventing JOSM to start...

[simon04]

Replying to Don-vip:

Please hold on any major change until Monday.

Alright. I'll probably work on a few highly experimental patches (such as #19336) instead... :-)