Modify

Opened 4 years ago

Closed 4 years ago

#20695 closed defect (fixed)

DownloadWmsAlongTrackActionTest.testTMSLayer fails on GitHub Actions

Reported by: simon04 Owned by: Don-vip
Priority: normal Milestone: 21.06
Component: Unit tests Version:
Keywords: progressmonitor downloadalong wms Cc: Don-vip, wiktorn

Description

Any idea why DownloadWmsAlongTrackActionTest.testTMSLayer fails on GitHub Actions? – https://github.com/openstreetmap/josm/runs/2226030659


org.openstreetmap.josm.gui.progress.ProgressException: Expected states are [IN_TASK, IN_SUBTASK] but current state is FINISHED
	at org.openstreetmap.josm.gui.progress.AbstractProgressMonitor.checkState(AbstractProgressMonitor.java:84)
	at org.openstreetmap.josm.gui.progress.AbstractProgressMonitor.internalUpdateProgress(AbstractProgressMonitor.java:266)
	at org.openstreetmap.josm.gui.progress.AbstractProgressMonitor.setTicks(AbstractProgressMonitor.java:244)
	at org.openstreetmap.josm.gui.progress.AbstractProgressMonitor.worked(AbstractProgressMonitor.java:258)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer$PrecacheTask.tileLoadingFinished(AbstractTileSourceLayer.java:1910)
	at org.openstreetmap.josm.data.imagery.TMSCachedTileLoaderJob.loadingFinished(TMSCachedTileLoaderJob.java:219)
	at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.finishLoading(JCSCachedTileLoaderJob.java:261)
	at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.run(JCSCachedTileLoaderJob.java:230)
	at java.base/java.lang.Thread.run(Thread.java:831)

Attachments (0)

Change History (4)

comment:1 by Don-vip, 4 years ago

These errors are the hard ones. No idea right now...

comment:2 by simon04, 4 years ago

@wiktorn, could this be related to r17494?

cachedTileLoader.cancelOutstandingTasks(); cachedTileLoader.shutdown(); is called for each loaded tile via PrecacheTask.tileLoadingFinished (9 times for DownloadWmsAlongTrackActionTest.testTMSLayer).

comment:3 by Don-vip, 4 years ago

Milestone: 21.06
Owner: changed from team to Don-vip
Status: newassigned

comment:4 by Don-vip, 4 years ago

Resolution: fixed
Status: assignedclosed

In 17975/josm:

fix #21090 - fix #20695 - shutdown precache tileloader only when all tiles have been loaded

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.