[Patch] Color NMEA and GPX files by "fix" value

[pyrog]

Hi,

NMEA tracks recorded by a RTK receiver already store the fix type (Single, RTK float, RTK fix).
This value is converted to text and stored in GpxConstants.PT_FIX field.

Unfortunately, this field is not used to set the colour of GPX track.
Doing this directly in JOSM would be great feature.

• GGA quality text conversion and stored in GpxConstants.PT_FIX field NmeaReader.java#L396
• RTKlib quality stored in GpxConstants.RTKLIB_Q field RtkLibPosReader.java#L94
• Colour selected GpxConstants.RTKLIB_Q in ColorMode.QUALITY GpxDrawHelper.java#L595

Both RTKLib and NMEA track could "share" the same quality field internally ?

RTK Lib	NMEA	Meaning
0	0	None ?
1	4	Fix RTK
2	5	Float RTK
3	?	SBAS
4	2	D-GPS
5	1	Single
6	3	PPK

Source: ticket #17829

When you look at a solution in rtkplot, the first thing you look is the points' colors.
The Q value set the color and the default one are:
Q=1 (fix) -> Green
Q=2 (float) -> Orange
Q=3 (sbas) -> Pink
Q=4 (dgps) -> Blue
Q=5 (single) -> Red
Q=6 (ppp) -> Light Blue

Source: NmeaReader.java#L396

// fix
accu = e[GGA.QUALITY.position];
if (!accu.isEmpty()) {
        int fixtype = Integer.parseInt(accu);
        switch(fixtype) {
        case 0:
                currentwp.put(GpxConstants.PT_FIX, "none");
                break;
        case 1:
                if (sat < 4) {
                        currentwp.put(GpxConstants.PT_FIX, "2d");
                } else {
                        currentwp.put(GpxConstants.PT_FIX, "3d");
                }
                break;
        case 2:
                currentwp.put(GpxConstants.PT_FIX, "dgps");
                break;
        case 3:
                currentwp.put(GpxConstants.PT_FIX, "pps");
                break;
        case 4:
                currentwp.put(GpxConstants.PT_FIX, "rtk");
                break;
        case 5:
                currentwp.put(GpxConstants.PT_FIX, "float rtk");
                break;
        case 6:
                currentwp.put(GpxConstants.PT_FIX, "estimated");
                break;
        case 7:
                currentwp.put(GpxConstants.PT_FIX, "manual");
                break;
        case 8:
                currentwp.put(GpxConstants.PT_FIX, "simulated");
                break;
        default:
                break;
        }
}

[anonymous]

I support this proposition. Indeed, this is my proposition.

I recorded the attached file using a F9P feed by centipede RTCM stream. NMEA was directly generated by the F9P.

[stoecker]

There is already a style to color NMEA data accordingly: Styles/ColourGPSData.

[pyrog]

Hi all,

Is it possible to reopen this ticket ?

The Styles/ColourGPSData is working but using it give several issues:

• The NMEA track must be converted to data layer
• This process is long with tracks of hundreds of kilometers
• This layer could be inadvertently merged or uploaded to osm
• When the data layer is not active, it's become black
• This process is not homogeneous with the process to colorise a .pos track

Also, the track could be colorise by age, reference station ID, standard deviation of horizontal error (see #21007)

[Eric_S]

I support the re-openning of this ticket, at least to have homogeneous behaviour with .pos files.

[Bjoeni]

Patch:

• color option for "fix" value from *.nmea and from *.gpx files
• read "fix" value from *.gpx files
• display names for RTKLib quality values

I think it's been established in the various tickets why the "ColourGPSData" style is good for some use cases but can't replace a coloring option, that's why I wrote this patch.

This means that for now there would be two coloring options, one for GPS fix values and one for the RTKLib quality values:

GPS fix	RTKLib quality

As suggested by pyrog, I too think it might actually make sense to put them together in one option at some point in the future (that probably means: converting RTKLib quality values to GPS fix values because there are more options) but I don't know enough about RTKLib values to say which ones are actually comparable/directly convertible.

The colors are pretty much random at this point, suggestions are welcome.

Followup tickets:

• #21007 - Import more data from NMEA GNSS tracks
• #21932 - Save NMEA / RTKLib values as extensions in .gpx files
• #21933 - Customization of GPS drawing options

[Bjoeni]

Ticket #13484 has been marked as a duplicate of this ticket.

[Bjoeni]

Ticket #20601 has been marked as a duplicate of this ticket.

[Bjoeni]

Ticket #21810 has been marked as a duplicate of this ticket.

[Bjoeni]

Ticket #21928 has been marked as a duplicate of this ticket.

[Bjoeni]

fix translation issues and add comments

[stoecker]

In 18396/josm:

fix #20600 - add Fix coloring for NMEA, patch by Bjoeni

[Eric_S]

Successfully checked with April update.

Thanks.