Validator: false-negative Test on street name "descriptive name" [Patch]

[kurt@…]

What steps will reproduce the problem?

1. run Validate e.g. on ​https://www.openstreetmap.org/way/25014585

What is the expected result?

no error

What happens instead?

Warning: descriptive name - name=Kapelle

Please provide any additional information below. Attach a screenshot if possible.

the street name is correct. Don't tell me again we should change a street name to match JOSM!!!!!!!!

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-02-22 12:27:24 +0100 (Mon, 22 Feb 2021)
Build-Date:2021-02-22 11:28:48
Revision:17523
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17523 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 1049 MB / 1820 MB (382 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
Dataset consistency test: No problems found

Plugins:
+ ImportImagePlugin (35567)
+ OpeningHoursEditor (35640)
+ PicLayer (2a9aa7a)
+ apache-commons (35524)
+ areaselector (368)
+ austriaaddresshelper (1597341117)
+ changeset-viewer (25)
+ easypresets (1605041256)
+ ejml (35458)
+ geotools (35458)
+ graphview (35640)
+ jaxb (35543)
+ jogl (1.2.3)
+ jts (35458)
+ log4j (35458)
+ opendata (35640)
+ reverter (35688)
+ scripting (30798)
+ terracer (35640)
+ utilsplugin2 (35691)

Tagging presets:
+ D:\<user.name>\Osmand\JOSM_Include\Heritage_NRW_preset.xml
+ D:\<user.name>\Osmand\JOSM_Include\<user.name>_preset.xml
+ D:\<user.name>\Osmand\JOSM_Include\street_lamp_preset.xml
+ D:\<user.name>\Osmand\JOSM_Include\Heritage_Austria_preset.xml

Map paint styles:
+ D:\<user.name>\Osmand\JOSM_Include\Style\Styles_AreaHighway.mapcss
- D:\<user.name>\Osmand\JOSM_Include\Style\Style_30zone.mapcss

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ http://www.openrailwaymap.org/validator/de-openrailwaymap.validator.mapcss
- https://josm.openstreetmap.de/josmfile?page=Rules/OsmoseValidations&zip=1

Last errors/warnings:
- 00008.784 E: Failed to locate image 'presets/bridge.png'
- 00008.784 W:  Bridge: Could not get presets icon presets/bridge.png
- 00008.784 E: Failed to locate image 'presets/tunnel.png'
- 00008.784 W:  Culvert: Could not get presets icon presets/tunnel.png
- 00008.784 E: Failed to locate image 'presets/tunnel.png'
- 00008.784 W:  Doppelhaushälfte: Could not get presets icon presets/tunnel.png
- 00008.794 E: Failed to locate image 'styles/standard/misc/streetlamp.png'
- 00008.794 W:  Light source: Could not get presets icon styles/standard/misc/streetlamp.png
- 00008.794 E: Failed to locate image 'Icon_bda.png'
- 00008.794 W:  Heritage Austria: Could not get presets icon Icon_bda.png

[mdk]

Maybe exclude street names from this test? Generally you find descriptive names ob objects which normally has no names.

[GerdP]

The mapcss test is wrong, the check doesn't check if the name is on an object with amenity=place_of_worship:

*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/], /* check if amenity=place_of_worship and/or building=chapel applies */

[skyper]

/* check if amenity=place_of_worship and/or building=chapel applies */
*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/][amenity=place_of_worship], 
*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/][building=chapel][amenity!=place_of_worship],

[skyper]

Replying to mdk:

Maybe exclude street names from this test? Generally you find descriptive names ob objects which normally has no names.

*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/][!highway], /* check if amenity=place_of_worship and/or building=chapel applies */

[GerdP]

It makes no sense to exclude highways. The test is about names that describe the property that is already given with the main tag. If there is no such tag we should simply remove the line.

[skyper]

Replying to skyper:

/* check if amenity=place_of_worship and/or building=chapel applies */
*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/][amenity=place_of_worship], 
*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/][building=chapel][amenity!=place_of_worship],

In one line:

*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/][tag("building")=="chapel"||tag("amenity")=="place_of_worship"], /* check if amenity=place_of_worship and/or building=chapel applies */

[GerdP]

Yes, that looks OK to me.

[mdk]

I had also more general cases in mind like Amenity=bench + name=bench.

[GerdP]

In 17630/josm:

fix #20560: Validator: false-negative Test on street name "descriptive name"

• limit test regarding chapel / chapelle /kapelle to objects which are chapels (Patch by skyper)