Modify

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#20531 closed enhancement (fixed)

Deprecate pump:type and man_made=pumping_rig

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 21.10
Component: Core validator Version:
Keywords: pump mechanism Cc:

Description

Dear maintainers,

Following approval of pumping proposal, some validation rules could be improved
https://wiki.openstreetmap.org/wiki/Proposed_features/Pumping_proposal

pump:type is deprecated in favor of pump_mechanism
https://wiki.openstreetmap.org/wiki/Key:pump:type

man_made=pumping_rig is also deprecated in favor of man_made=petroleum_well or man_made=water_well depending on its purpose
https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dpumping_rig

Such keys should raise a warning towards mappers as to encourage them to update outdated features.

Thanks in advance

Attachments (0)

Change History (11)

comment:1 by Don-vip, 4 years ago

Keywords: pump, pump mechanism → pump mechanism

comment:2 by Don-vip, 4 years ago

Milestone: 21.04
Owner: changed from team to Don-vip
Status: newassigned

comment:3 by simon04, 4 years ago

Milestone: 21.0421.05

comment:4 by simon04, 4 years ago

Milestone: 21.0521.06

comment:5 by Don-vip, 3 years ago

Milestone: 21.0621.07

comment:6 by Don-vip, 3 years ago

Milestone: 21.0721.08

comment:7 by Don-vip, 3 years ago

Owner: changed from Don-vip to team
Status: assignednew

I can't find enough time to finish this :( If anyone wants to do it, go. If not, I'll take it back after my holidays, in September.

comment:8 by Don-vip, 3 years ago

Milestone: 21.0821.09

comment:9 by skyper, 3 years ago

Oh, I did not know we already had an own ticket for this.
My patch in #20530 includes a fix for this ticket, now.

comment:10 by Don-vip, 3 years ago

Resolution: fixed
Status: newclosed

In 18230/josm:

fix #20530 - fix #20531 - Add man_made pump preset, deprecate man_made=pumping_rig, pump:type=* and substance=heat (patch and icons by skyper, François Lacombe and gaben)

comment:11 by Don-vip, 3 years ago

Milestone: 21.0921.10

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.