Happened while doing.. nothing!

[mrgenie@…]

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-02-10 08:45:14 +0100 (Wed, 10 Feb 2021)
Build-Date:2021-02-11 02:30:51
Revision:17489
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17489 en) Windows 10 64-Bit
OS Build number: Windows 10 Home Single Language 2004 (19041)
Memory Usage: 1350 MB / 1820 MB (887 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 3840×2160 (scaling 1.00×1.00)
Maximum Screen Size: 3840×2160
Best cursor sizes: 16×16→32×32, 32×32→32×32
Dataset consistency test: No problems found

Plugins:
+ DirectDownload (35640)
+ ElevationProfile (35640)
+ Mapillary (1.5.37.1)
+ apache-commons (35524)
+ apache-http (35589)
+ continuosDownload (91)
+ imagery_offset_db (35640)
+ javafx-windows (35655)
+ jna (35662)
+ turnrestrictions (35640)

Tagging presets:
+ <josm.pref>\Phillipines_Jeepney\Phillipines_Jeepney.xml

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
+ %UserProfile%\Documents\elemstyles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/ColourGPSData&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1

Last errors/warnings:
- 27179.340 E: Handled by bug report queue: java.lang.IllegalStateException: Can't obtain secrets from user
- 27179.340 W: Too many errors. Dropping ReportedException [thread=Thread[pool-6-thread-79,5,main], exception=java.lang.IllegalStateException: Can't obtain secrets from user, methodWarningFrom=BugReportExceptionHandler#handleException]
- 27179.341 E: Handled by bug report queue: java.lang.IllegalStateException: Can't obtain secrets from user
- 27179.341 W: Too many errors. Dropping ReportedException [thread=Thread[pool-6-thread-78,5,main], exception=java.lang.IllegalStateException: Can't obtain secrets from user, methodWarningFrom=BugReportExceptionHandler#handleException]
- 27179.342 E: Handled by bug report queue: java.lang.IllegalStateException: Can't obtain secrets from user
- 27179.342 W: Too many errors. Dropping ReportedException [thread=Thread[pool-6-thread-77,5,main], exception=java.lang.IllegalStateException: Can't obtain secrets from user, methodWarningFrom=BugReportExceptionHandler#handleException]
- 27179.343 E: Handled by bug report queue: java.lang.IllegalStateException: Can't obtain secrets from user
- 27179.343 W: Too many errors. Dropping ReportedException [thread=Thread[pool-6-thread-76,5,main], exception=java.lang.IllegalStateException: Can't obtain secrets from user, methodWarningFrom=BugReportExceptionHandler#handleException]
- 27179.344 E: Handled by bug report queue: java.lang.IllegalStateException: Can't obtain secrets from user
- 27179.344 W: Too many errors. Dropping ReportedException [thread=Thread[pool-6-thread-75,5,main], exception=java.lang.IllegalStateException: Can't obtain secrets from user, methodWarningFrom=BugReportExceptionHandler#handleException]



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: pool-6-thread-1 (4754)
java.lang.IllegalStateException: Can't obtain secrets from user
	at org.openstreetmap.josm.plugins.mapillary.oauth.UploadUtils.upload(UploadUtils.java:218)
	at org.openstreetmap.josm.plugins.mapillary.oauth.UploadUtils$SequenceUploadRunnable.lambda$run$1(UploadUtils.java:105)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

[taylor.smock]

Hopefully (quick) question: Are you ever logged into Mapillary in the plugin?

[taylor.smock]

Nevermind. Your bug report is missing important information.

Happened while doing.. nothing! cannot be correct. The only way to hit that code path is to attempt to upload some images to Mapillary. You were not logged in, which is why the crash occurred when you tried to upload.

Anyway, I will probably be removing any way to modify Mapillary images in the next month or two (including uploads), so I'm closing this as wontfix, as it will be fixed via the removal.

For the record:
Only reference to org.openstreetmap.josm.plugins.mapillary.oauth.UploadUtils.upload is in org.openstreetmap.josm.plugins.mapillary.oauth.UploadUtils.SequenceUploadRunnable which is only referred to by org.openstreetmap.josm.plugins.mapillary.oauth.UploadUtils.uploadSequence(MapillarySequence, boolean), which is only referred to by org.openstreetmap.josm.plugins.mapillary.actions.MapillaryUploadAction.actionPerformed.

[anonymous]

Hi, yeah well I, me personally, was doing nothing..

I started an upload.. and it uploads 10, 20, 30, images and at some part during the upload the Mapillary logs me out automatically.

It's true, you're right, this only happens during upload OR download..

But yeah, I - as in me personally - doing nothing! LOL

I just start an upload.. it starts to upload.. i go make me a coffee.. when I return error LOL

But you already said you're going to delete the functionality to upload to Mapillary that's fine..

I found out the webuploader works perfect for 1000+ images without hiccups so going to use that to upload.

Thanks

[taylor.smock]

I found out the webuploader works perfect for 1000+ images without hiccups so going to use that to upload.

This is probably the best way to do it if you aren't constantly uploading. You could also use one of the other officially supported by Mapillary upload tools. Personally, I use ​https://github.com/mapillary/mapillary_tools , but ​https://help.mapillary.com/hc/en-us/articles/115001472029-Different-upload-methods has some additional methods.

[taylor.smock]

​https://blog.mapillary.com/update/2021/03/03/preparing-for-the-new-mapillary-api.html

The current API endpoints used for uploading will be removed, and I am much more concerned about supporting the basic features of the Mapillary plugin.

I may be able to re-add upload later, but it won't be a priority for me.