#20471 closed defect (fixed)
[Patch] Suspicious combination: False positive on power=cable + tunnel=yes
Reported by: | Gazer75 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 21.04 |
Component: | Core validator | Version: | |
Keywords: | combination power cable tunnel | Cc: | francois.lacombe |
Description
Validator flags this as suspicious. Using this combination is valid for cables that are in tunnels. Typically used under cities or out from hydro power stations inside mountains.
Attachments (1)
Change History (15)
comment:1 by , 4 years ago
Keywords: | power added |
---|
comment:2 by , 4 years ago
Cc: | added |
---|---|
Keywords: | cable tunnel added |
comment:3 by , 4 years ago
However we don't use location=tunnel with highways that runs in a tunnel mapped with a dedicated feature, nor bridges as well.
Such a change should be discussed on wiki or @tagging prior to get on JOSM stash.
comment:4 by , 4 years ago
Wait a minute, I was not talking about changing tunnel=yes
to location=tunnel
, in general, but use it for power=cable
.
tunnel=yes
is mentioned on the wiki but I did not find this combination in the data, according to taginfo.
Are there any other power=*
which are running through tunnel?
comment:5 by , 4 years ago
I was indeed dealing with tunnel=yes and location=underground meaning for power=cable only. Changing (and discussing) this should be done on wiki actually.
tunnel=yes + power=cable should be used here for instance, regarding London Power tunnels : https://www.openstreetmap.org/way/447728811
https://cdn.ca.emap.com/wp-content/uploads/sites/9/2018/02/Cables-installation-from-tunnel-into-shaft1.jpg
Let's sum up existing possible tagging with this:
- location=underground + power=cable, cables are buried underground and you can't visit them
- tunnel=yes + power=cable (+ location=underground optional), cables are installed in a tunnel you can visit
To me, location=tunnel + power=cable could mean power cables are installed in a tunnel we can visit but the tunnel is mapped with another dedicated feature, that's my 2 cts.
comment:6 by , 4 years ago
Ok, I remember similar situations with (un-)covered waterways in tunnels next to or below paths.
So, power=cable
is the only way from power=*
which should be allowed to have a tunnel=yes
. Is tunnel=culvert
ok ?
follow-up: 8 comment:7 by , 4 years ago
Cables can also be in tunnel and under ground ;)
Technically it is already under ground when in a tunnel, but road tunnels will usually have power cables dug in along the road edge. So then the cable is under ground and in a tunnel :)
comment:8 by , 4 years ago
So the change is quite simple: josm_20471.patch
Replying to Gazer75:
Cables can also be in tunnel and under ground ;)
Technically it is already under ground when in a tunnel, but road tunnels will usually have power cables dug in along the road edge. So then the cable is under ground and in a tunnel :)
Interesting: power=cable
, tunnel=[yes|culvert]
, covered=yes
, location=[underground|tunnel]
, layer=-[2-5]
? And do not forget to add it to the tunnel relation.
comment:9 by , 4 years ago
Summary: | Validator on power=cable + tunnel=yes → [Patch] Validator on power=cable + tunnel=yes |
---|
comment:10 by , 4 years ago
Keywords: | combination added |
---|---|
Summary: | [Patch] Validator on power=cable + tunnel=yes → [Patch] Suspicious combination: False positive on power=cable + tunnel=yes |
comment:12 by , 4 years ago
Milestone: | → 21.04 |
---|
Most of the
power=cable
probably need onlylocation=*
, so I wonder if we could uselocation=tunnel
instead oftunnel=*
.