Sorting does not work correctly in Conflation plugin

[anonymous]

What steps will reproduce the problem?

1. Upload two files in JOSM
2. Select only ways for both of them
3. Make the conflation
4. Sort the columns by 'Subject'
5. Check the results

What is the expected result?

The sorting from biggest to lowest happens correctly

What happens instead?

The sorting gives wrong result

Please provide any additional information below. Attach a screenshot if possible.

In case the user sorts the 'Subject' column from biggest to lowest, then in some cases the constraint is not respected (e.g. in my case 33568 is between 32772 and 32773). This causes an significant problem, since the scores cannot be assigned to the correct building, and therefore, there is no way to understand which building corresponds to which score.

Till now I was not able to identify a pattern for which the issue always appears.

Your plugin is extremely useful and I would be more than happy if you manage to fix it as soon as possible. I would consider this bug as a blocker, since I can not use the scores if I will not be able to identify to which building they correspond to.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-21 14:56:29 +0100 (Sat, 21 Nov 2020)
Build-Date:2020-11-22 02:30:52
Revision:17329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17329 en_GB) Windows 8.1 64-Bit
OS Build number: Windows 8.1 (9600)
Memory Usage: 1107 MB / 1820 MB (336 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1366x768 (scaling 1.0x1.0)
Maximum Screen Size: 1366x768
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ conflation (0.6.6)
+ jts (35458)
+ utilsplugin2 (35674)

[axipap@…]

In the the file there are attached the two files with which the issue can be reproduced. Also, there is screenshot that shows the settings that need to be used in order to reproduce the issue. A video is also attached, which shows the issue.

[skyper]

The plugin works and sorting is only one use case, e.g. no blocker.

[Tyndare]

I don't understand what you mean by:

the scores cannot be assigned to the correct building

I don't see bug in score assignment, the sorting have no impact on the association between the score and the items.

If you want to identify which building correspond to a score you can double click on a row to select it.

Concerning the sorting issue, I think I finally understood what's going on.

Sorting "Subject" or "Reference" column use JOSM intrinsic order of corresponding OSM primitives object.
And the order is not based on the properties of items but only on the value of the intrinsic OpenStreetMap id.

As it is not an OpenStreetMap file you open, I assume JOSM will assign each item an intrinsic id in the order they appear in the .geojson file.

A workaround if you want the order to match the one of the FID property might be to sort your geojson file prior to loading it into JOSM.

I think that sorting items by their properties value should be considered a feature request rather that a bug, I don't know how to implement it for now. Do you know other JOSM function or plugin that already sort items by their properties values ?

[axipap]

Thank for your answer. In fact, sorting even by FID property works, but it does not work for all cases. I will try also your proposal and let you know if this would work for me. In the meantime, I developed another way to match each score with the respective FID by using the geometry. Also, it would be very useful, if the user could copy the table with the results including not only score and distance column, but also properties (e.g. FID). I guess, though, this is more on feature request side.

Do you know other JOSM function or plugin that already sort items by their properties values ?
No, I never tried to sort items by their properties values with another JOSM function or plugin .