Ignore list: Misleading entry "Presets do not contain property key"

[GerdP]

What steps will reproduce the problem?

1. Have some unit test data where lots of objects have a tag expected_code=*
2. Run validator
3. Find lots of "Other" messages Presets do not contain property key - Key 'expected_code' not in presets.
4. Select that entry and click Ignore and click "Whole group"

What is the expected result?

Ignore list shows an entry for the specific tag key 'expected_code'

What happens instead?

Ignore list show an entry Presets do not contain property key. Since I don't want to ignore all those messages I got nervous.

Please provide any additional information below. Attach a screenshot if possible.

Found this while working on data for a unit test. In fact the ignore list contains the wanted specific entry, it just doesn't show it unless you click on the +. Not sure if this can/should be fixed.

Ignore list in preferernces.xml:

  <maps key='validator.ignorelist'>
    <map>
      <tag key='1201_Key &apos;expected_code&apos; not in presets.' value='Presets do not contain property key'/>
      <tag key='3000_Unnamed unclassified highway' value='Unnamed unclassified highway'/>
      <tag key='303' value='Unnamed ways'/>
    </map>
  </maps>

Build-Date:2020-12-13 12:15:19
Revision:17405
Is-Local-Build:true

Identification: JOSM/1.5 (17405 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 926 MB / 1820 MB (581 MB allocated, but free)
Java version: 1.8.0_272-b10, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:51099, -ea, -javaagent:D:\eclipse-java-2020-09\eclipse\configuration\org.eclipse.osgi\215\0\.cp\lib\javaagent-shaded.jar, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

[GerdP]

@Taylor: What do you think? I don't remember if this is intended or not. Same case with messages from mapcss tests (code 3000)

Maybe we should simply always expand those items which contain keys matching the pattern "^[0-9]+_.*$"?

[taylor.smock]

Replying to GerdP:

@Taylor: What do you think? I don't remember if this is intended or not. Same case with messages from mapcss tests (code 3000)

Maybe we should simply always expand those items which contain keys matching the pattern "^[0-9]+_.*$"?

I honestly don't remember if this was intended or not. Probably not a conscious decision, if so.

As far as expansions go, if we do expand the tree, we should probably expand until the child nodes match ^[nwr]_[0-9]+$. This will avoid cases where we have the root node as Presets do not contain property key with a child node of 1201_Key 'key' not in presets. while not expanding the 1201_Key... entry if it has a specific value (i.e., w_123).