[Patch] False positive from RelationChecker for Fietsnetwerk/Radknotenpunktsystem ?

[GerdP]

What steps will reproduce the problem?

1. Validate a relation like ​r1203658 (Fietsnetwerk Twente) which has hundrets of node members with empty role and tags

   name=Fietsnetwerk Twente
   network:type=node_network
   network=rcn
   type=network
   

What is the expected result?

In Germany we have them as well, e.g. ​r10572031 name=Radknotenpunktsystem Landkreis Oldenburg. I guess those relations must contain nodes, so I am not sure what's wrong exactly.

What happens instead?

Hundreds of warnings Type 'node' of relation member with role '' does not match accepted types 'relation' in preset Route Network (574)

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2020-12-02 10:37:13
Revision:17384
Is-Local-Build:true

Identification: JOSM/1.5 (17384 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 1346 MB / 3641 MB (390 MB allocated, but free)
Java version: 1.8.0_272-b10, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:55380, -ea, -javaagent:D:\eclipse-java-2020-09\eclipse\configuration\org.eclipse.osgi\215\0\.cp\lib\javaagent-shaded.jar, -Dfile.encoding=UTF-8]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
+ ColumbusCSV (35640)
+ buildings_tools (35640)
+ o5m (35640)
+ pbf (35650)
+ poly (35640)
+ reltoolbox (35640)
+ reverter (35640)
+ undelete (35640)
+ utilsplugin2 (35640)

Validator rules:
+ c:\josm\core\resources\data\validator\geometry.mapcss

Last errors/warnings:
- 00284.015 W: should use ChangeMembersCommand
- 00392.847 W: should use ChangeMembersCommand

[GerdP]

Is this something that should be fixed in the presets or do we need a change in RelationChecker?

[skyper]

This needs to be fixed in the preset by adding an own preset for type=network plus network:type=node_network relations.

Maybe, this tag combo can be ignored otherwise.

[skyper]

I can have a look at this. Would a new preset for this kind of network accepted?

[Don-vip]

If it's established tagging, sure.

[skyper]

patch

[skyper]

Please, find attached patch file, josm_20210.patch​ which adds route node network relations as new preset and fixes the validation for network relations.
It does not handle/fix the similar validator warning about the route relations: Type 'node' of relation member with role '' does not match accepted types 'way/closedway' in preset Bicycle Route (458) which would need another own preset for node network route relations.

All along, I am not sure if node network relations, should be included as, so far, they are only present in a few European countries.

[Don-vip]

In 18081/josm:

fix #20210 - add route node network relation as new preset and fix validation for network relations (patch by skyper)

[skyper]

Replying to skyper:

It does not handle/fix the similar validator warning about the route relations: Type 'node' of relation member with role '' does not match accepted types 'way/closedway' in preset Bicycle Route (458) which would need another own preset for node network route relations.

According to the documentation on the wiki, the nodes are not needed in the route relation.

I forgot to add riding, though, which I've added in #21161 along with some member_expression updates.