JOSM frozen when upload data

[slayzex@…]

What steps will reproduce the problem?

1. download big relation
2. editing something
3. then start upload data

What is the expected result?

validating of changed data

What happens instead?

JOSM hangup before validation

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Revision:17084
Build-Date:2020-10-04 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17084 uk) Linux Manjaro Linux
Memory Usage: 229 MB / 934 MB (71 MB allocated, but free)
Java version: 14.0.2+12, N/A, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600x900 (scaling 1.0x1.0)
Maximum Screen Size: 1600x900
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Desktop environment: GNOME
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (35583)
+ CommandLine (35583)
+ CustomizePublicTransportStop (35583)
+ DirectDownload (35552)
+ DirectUpload (35583)
+ EasyPresets (1595741614)
+ FastDraw (35499)
+ FixAddresses (35583)
+ HouseNumberTaggingTool (35581)
+ Mapillary (1.5.27)
+ OpeningHoursEditor (35579)
+ QuickLabel (18)
+ RelationDissolve (0.2.0)
+ SimplifyArea (35579)
+ apache-commons (35524)
+ apache-http (35092)
+ auto_tools (73)
+ buildings_tools (35579)
+ changeset-viewer (22)
+ editgpx (35248)
+ ejml (35313)
+ highwayNameModification (0.0.9)
+ imagery_offset_db (35405)
+ javafx-unixoid (35458)
+ jaxb (35092)
+ jna (35092)
+ mapathoner (1.0.9-2-g7d7a1c7)
+ mapwithai (1.6.4)
+ markseen (14)
+ measurement (35579)
+ namemanager (35248)
+ osm-obj-info (56)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ rasterfilters (35405)
+ reltoolbox (35529)
+ reverter (35579)
+ tageditor (35258)
+ todo (30306)
+ turnrestrictions (35583)
+ undelete (35521)
+ utilsplugin2 (35580)
+ waydownloader (35405)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Addr2&zip=1
+ https://raw.githubusercontent.com/gontsa/josm-christianity-ua/master/christian-ua.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1

Last errors/warnings:
- 00021,764 W:  Confessional school: Could not get presets icon 
- 00021,766 E: Збій пошуку зображення ''
- 00021,767 W:  Confessional shop: Could not get presets icon 
- 00021,776 E: Збій пошуку зображення ''
- 00021,777 W:  Church Land: Could not get presets icon 
- 00021,790 E: Збій пошуку зображення ''
- 00021,792 W:  Monastery land: Could not get presets icon 
- 00022,877 E: Пошкоджено заготовку теґів "building:use-Building use" — кількість елементів у 'display_values' повинна дорівнювати кількості 'values'
- 00022,882 E: Докладна інформація: [] <> [place_of_worship, warehouse, industrial, commercial, residential]
- 00027,002 E: Збій пошуку зображення 'https://mkrada.gov.ua/favicon.ico'

[slayzex]

For example: i edited relation 2858550 and successfully upload it to server, but realation 2860380, i can`t upload

[GerdP]

This probably depends on the data that you download and the changes that you make. Please try your edit again and save to file before trying to upload. If the upload still doesn't work attach the file here.

[slayzex]

In attached file I just deleted admin_level=8 and changed boundary tag to boundary=admisitrative

[anonymous]

Replying to slayzex:

In attached file I just deleted admin_level=8 and changed boundary tag to boundary=admisitrative

sorry boundary ti boundary=historic

[GerdP]

I see no problems when I try to upload. What goes on when JOSM hangs? Is it consuming CPU time?

[anonymous]

Replying to GerdP:

I see no problems when I try to upload. What goes on when JOSM hangs? Is it consuming CPU time?

Usually it is not. Now I have modify couple of neighbor relations and then modify attached relation, and its uploaded. But i have relation of street, and when I modify it JOSM had hanging.

[slayzex]

All working OK, when it is switched off validation on upload. I need to keep in mind to checking errors manually before uploading :)

[skyper]

So, you can run validator with the same test manually, but on upload these tests hang? That would be strange. Some plugins also provide validator rules, so please try it without plugins.

[GerdP]

Replying to skyper:

So, you can run validator with the same test manually, but on upload these tests hang? That would be strange. Some plugins also provide validator rules, so please try it without plugins.

In fact we have flags to signal that validator is checking for update or not, so different results are expected. Most tests though should return the same result when all modified and new objects are selected.
I agree that plugins can be the problem, esp. if no cpu time is used. I have seen long delays with the upload dialog when the downloaded data contains eiher really complex and complete(!) multipolygon relations or a huge amount of completely incomplete relations (no member downloaded). In both cases one processor was very busy.

[skyper]

Ok, this could explain it.

I would expect to get less results, as less objects are evaluated, but the results of the test should be identical.

I understand the time spend for complex and complete MPs. For incomplete relations without any downloaded member it probably just takes time to check on all members where as with members you can stop once you'll find one incomplete and one complete member. Is there a way to know how many members are complete/incomplete in advance?

[GerdP]

For incomplete relations without any downloaded member...

I don't remember the details. Can't reproduce the problem. I think the problem with those relations was that they produce lots of objects which don't have a bbox and the spatial index had to handle them in sequential searches.

[slayzex]

I have left a minimum of plugins, and uploading of assotatedStreet working fine even with validation on uploading. And now, like a sapper, I would add some plugins, who knows maybe I will find that bad conditions.

[skyper]

Sorry, do not know that many plugins. From your list I know that wikipedia and pt_assistant add validator test.

If you can narrow it down to associatedStreet relations I would check the plugins for addresses, first.