[PATCH] Streetside plugin crashes after data is displayed on the map.

[jBeata]

What steps will reproduce the problem?

1. Install the plugin with all the dependencies
2. Go to JOSM -> Preferences -> Display settings -> Streetside -> select "everything in the visible area" Download mode
3. Zoom to a desired area of mapping.
4. Add Streetside layer
5. Data is displayed on the map, but JOSM crashes with the following error:

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Revision:17084
Build-Date:2020-10-04 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17084 en_GB) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H2)
Memory Usage: 453 MB / 2048 MB (26 MB allocated, but free)
Java version: 11.0.6+10, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 188942015 1920x1080 (scaling 1.0x1.0), Display 69734662 1792x1120 (scaling 2.0x2.0)
Maximum Screen Size: 1920x1120
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DApplicationDirectory=${HOME}/Applications, -DAutosavedInformationDirectory=${HOME}/Library/Autosave Information, -DDesktopDirectory=${HOME}/Desktop, -DDownloadsDirectory=${HOME}/Downloads, -DMoviesDirectory=${HOME}/Movies, -DMusicDirectory=${HOME}/Music, -DPicturesDirectory=${HOME}/Pictures, -DSharedPublicDirectory=${HOME}/Public, -DSystemLibraryDirectory=/Library, -DSystemApplicationSupportDirectory=/Library/Application Support, -DSystemCachesDirectory=/Library/Caches, -DSystemApplicationDirectory=/Applications, -DSystemUserDirectory=/Users, -DUserHome=${HOME}, -DSandboxEnabled=true, -DLaunchModifierFlags=0, -DLaunchModifierFlagCapsLock=false, -DLaunchModifierFlagShift=false, -DLaunchModifierFlagControl=false, -DLaunchModifierFlagOption=false, -DLaunchModifierFlagCommand=false, -DLaunchModifierFlagNumericPad=false, -DLaunchModifierFlagHelp=false, -DLaunchModifierFlagFunction=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]

Plugins:
+ ImproveOsm (202)
+ Mapillary (1.5.27)
+ MicrosoftStreetside (35248)
+ OpenStreetCam (350)
+ apache-commons (35524)
+ apache-http (35092)
+ javafx-osx (35458)
+ jna (35092)
+ mapwithai (1.6.4)
+ utilsplugin2 (35624)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 00003.199 E: java.lang.UnsatisfiedLinkError: <josm.userdata>/plugins/javafx/libjfxmedia_avf.dylib: dlopen(<josm.userdata>/plugins/javafx/libjfxmedia_avf.dylib, 1): Library not loaded: @rpath/libgstreamer-lite.dylib
- 00003.203 E: java.lang.UnsatisfiedLinkError: <josm.userdata>/plugins/javafx/libfxplugins.dylib: dlopen(<josm.userdata>/plugins/javafx/libfxplugins.dylib, 1): Library not loaded: @rpath/libgstreamer-lite.dylib
- 00025.462 E: Handled by bug report queue: java.lang.NoClassDefFoundError: org/apache/commons/jcs/access/behavior/ICacheAccess. Cause: java.lang.ClassNotFoundException: org.apache.commons.jcs.access.behavior.ICacheAccess
- 00120.825 E: Handled by bug report queue: java.lang.NoClassDefFoundError: org/apache/commons/jcs/access/behavior/ICacheAccess. Cause: java.lang.ClassNotFoundException: org.apache.commons.jcs.access.behavior.ICacheAccess


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (20) of main
java.lang.NoClassDefFoundError: org/apache/commons/jcs/access/behavior/ICacheAccess
	at org.openstreetmap.josm.plugins.streetside.gui.StreetsideMainDialog.updateImage(StreetsideMainDialog.java:229)
	at org.openstreetmap.josm.plugins.streetside.mode.SelectMode.mouseMoved(SelectMode.java:177)
	at java.desktop/java.awt.AWTEventMulticaster.mouseMoved(AWTEventMulticaster.java:338)
	at java.desktop/java.awt.Component.processMouseMotionEvent(Component.java:6677)
	at java.desktop/javax.swing.JComponent.processMouseMotionEvent(JComponent.java:3360)
	at java.desktop/java.awt.Component.processEvent(Component.java:6401)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5008)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4840)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4560)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4840)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.jcs.access.behavior.ICacheAccess
	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:588)
	at org.openstreetmap.josm.plugins.PluginClassLoader.loadClass(PluginClassLoader.java:73)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
	... 33 more

[Don-vip]

- 00003.199 E: java.lang.UnsatisfiedLinkError: <josm.userdata>/plugins/javafx/libjfxmedia_avf.dylib: dlopen(<josm.userdata>/plugins/javafx/libjfxmedia_avf.dylib, 1): Library not loaded: @rpath/libgstreamer-lite.dylib
- 00003.203 E: java.lang.UnsatisfiedLinkError: <josm.userdata>/plugins/javafx/libfxplugins.dylib: dlopen(<josm.userdata>/plugins/javafx/libfxplugins.dylib, 1): Library not loaded: @rpath/libgstreamer-lite.dylib
- 00025.462 E: Handled by bug report queue: java.lang.NoClassDefFoundError: org/apache/commons/jcs/access/behavior/ICacheAccess. Cause: java.lang.ClassNotFoundException: org.apache.commons.jcs.access.behavior.ICacheAccess
- 00120.825 E: Handled by bug report queue: java.lang.NoClassDefFoundError: org/apache/commons/jcs/access/behavior/ICacheAccess. Cause: java.lang.ClassNotFoundException: org.apache.commons.jcs.access.behavior.ICacheAccess

I see you're running macOS, which build are you using? The .zip from josm.openstreetmap.de or the new builds from GitHub?

[taylor.smock]

I'm pretty certain that it is fallout from #19208 . I think I got distracted by other projects I had to work on, so I never got the patch for MS Streetside fully working (it needed some build updates).

java.lang.NoClassDefFoundError: org/apache/commons/jcs/access/behavior/ICacheAccess shows the issue (jcs -> jcs3 fixes the problem).

[taylor.smock]

Update patch for changes, now with working tests (ant test/./gradlew test). Fails with ./gradlew build due to non-conformant code. Code can be made conformant with ./gradlew spotlessApply or the spotless plugin can be removed (since the coding style wasn't always followed).

[Don-vip]

@Taylor, the patch doesn't apply nicely for build.gradle.

[Stereo]

I see you're running macOS, which build are you using? The .zip from josm.openstreetmap.de or the new builds from GitHub?

It's Java version: 11.0.6+10, AdoptOpenJDK, so neither of the above. I'm curious now :).

Javafx won't work in the new macOS builds anyway.

[taylor.smock]

Replying to Don-vip:

@Taylor, the patch doesn't apply nicely for build.gradle.

Which "version" of MS Streetside are you applying the patch to?

The last modification for me was 35601 (is this the last one for you as well?). I'll attach another patch just in case something got corrupted with patch v2.

[taylor.smock]

Same as 19208.streetside_build.2.patch

[Don-vip]

Replying to taylor.smock:

Which "version" of MS Streetside are you applying the patch to?

latest SVN, like any other patch. Still doesn't apply:

[taylor.smock]

Yet Another Patch (hopefully works -- worked for me with Eclipse/patch, with revision 35601)

[taylor.smock]

Replying to Don-vip:

Replying to taylor.smock:

Which "version" of MS Streetside are you applying the patch to?

latest SVN, like any other patch. Still doesn't apply:

Awesome. I was pretty certain I was on latest SVN , but it looks like I missed your previous patch for bumping the JOSM version, which caused a conflict in gradle.properties. But not build.gradle, which is where you are seeing conflicts.

[Don-vip]

Still the exact same problem :'(

[taylor.smock]

Replying to Don-vip:

Still the exact same problem :'(

Can you attach the offending file to this ticket? (build.gradle if I'm reading the output correctly)

I'm wondering if I messed something up somewhere such that I think I have the current version of MicrosoftStreetside when I do not.

[Don-vip]

Sure, here it is: attachment:build.gradle​

[taylor.smock]

Replying to Don-vip:

Sure, here it is: attachment:build.gradle​

Well, that is the same build.gradle I'm making the diff against (I used vimdiff to compare my local version versus attachment:build.gradle​ and source:osm/applications/editors/josm/plugins/MicrosoftStreetside/build.gradle​, and there were no differences).

Possible explanations: I converted ‹unknown› to <Unknown> (I think I had some issues compiling due to the unicode, and I know that different operating systems handle non-ascii stuff slightly differently).

What happens if you run patch -p0 < ${PATH_TO_PATCH} in the MicrosoftStreetside directory?

[taylor.smock]

Drop change for unknown versions

[taylor.smock]

Ping to bring this back from the dead

[taylor.smock]

Patch update

[Don-vip]

In 35779/osm:

fix #19998 - update Streetside dependencies (patch by taylor.smock, modified)

[Don-vip]

In 35780/osm:

see #19998 - dist